Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented May 14, 2025

Changelog entry

Issue #18290

The TEvReadSet message can be sent again. When it was first sent, it was serialized and stored as a string. It turned out that the serialized message takes up a lot of memory space. For transactions with a large number of participants, this takes up a lot of space.

I changed it so that a copy of the data is stored to create a TEvReadSet when resending.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 14, 2025 09:42
@Alek5andr-Kotov Alek5andr-Kotov changed the title TEvReadSet занимают много памяти The serialized TEvReadSet takes up a lot of memory May 14, 2025
@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 09:45:43 UTC Pre-commit check for 7a8b900 has started.
2025-05-14 09:48:19 UTC Build linux-x86_64-relwithdebinfo is running...

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 09:49:15 UTC Pre-commit check for 7a8b900 has started.
2025-05-14 09:51:56 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-14 10:16:37 UTC Build successful.
2025-05-14 10:16:53 UTC Tests are running...
🔴 2025-05-14 10:20:03 UTC Test run completed, no test results found for commit 5783247. Please check test log.

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 10:27:49 UTC Pre-commit check for c5dc0a5 has started.
2025-05-14 10:30:25 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-14 10:54:34 UTC Build successful.
2025-05-14 10:54:49 UTC Tests are running...
🔴 2025-05-14 11:03:46 UTC Test run completed, no test results found for commit ba40d13. Please check test log.

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:13:27 UTC Pre-commit check for 4a7c27a has started.
2025-05-14 11:16:30 UTC Build linux-x86_64-release-asan is running...
2025-05-14 11:16:58 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:23:56 UTC Pre-commit check for c23fc2b has started.
2025-05-14 11:26:39 UTC Build linux-x86_64-release-asan is running...

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge May 14, 2025 11:27
@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:32:02 UTC Pre-commit check for c23fc2b has started.
2025-05-14 11:35:04 UTC Build linux-x86_64-relwithdebinfo is running...
2025-05-14 11:40:22 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:48:02 UTC Pre-commit check for 4fef929 has started.
2025-05-14 11:50:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-05-14 12:31:08 UTC Build successful.
2025-05-14 12:31:29 UTC Tests are running...
🔴 2025-05-14 13:59:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14825 13468 0 19 1300 38

🟢 2025-05-14 14:01:07 UTC ydbd size 8.3 GiB changed* by -105.0 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: acbb460 merge: 4fef929 diff diff %
ydbd size 8 899 008 352 Bytes 8 898 900 832 Bytes -105.0 KiB -0.001%
ydbd stripped size 485 044 552 Bytes 485 044 360 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:48:07 UTC Pre-commit check for 4fef929 has started.
2025-05-14 11:50:51 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-14 12:15:06 UTC Build successful.
2025-05-14 12:15:28 UTC Tests are running...
🔴 2025-05-14 14:30:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10394 10283 0 42 28 41

🟢 2025-05-14 14:31:04 UTC ydbd size 5.6 GiB changed* by -32.3 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: acbb460 merge: 4fef929 diff diff %
ydbd size 6 028 291 672 Bytes 6 028 258 584 Bytes -32.3 KiB -0.001%
ydbd stripped size 1 508 560 000 Bytes 1 508 559 488 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 9d4ad3c into ydb-platform:stable-24-4 May 14, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants