25-1 EnableLocalDBBtreeIndex = true (#19440)

Author: kunga

ydb/core/protos/feature_flags.proto

@@ -131,7 +131,7 @@ message TFeatureFlags {
  optional bool EnableStatistics = 106 [default = true];
  optional bool EnableUuidAsPrimaryKey = 107 [default = true];
  optional bool EnableTablePgTypes = 108 [default = false];
- optional bool EnableLocalDBBtreeIndex = 109 [default = false];
+ optional bool EnableLocalDBBtreeIndex = 109 [default = true];
  optional bool EnablePDiskHighHDDInFlight = 110 [default = false];
  reserved 111; // UseVDisksBalancing
  optional bool EnableViews = 112 [default = true];

ydb/core/tablet_flat/flat_executor_ut.cpp

@@ -6719,14 +6719,14 @@ Y_UNIT_TEST_SUITE(TFlatTableExecutor_BTreeIndex) {
  }
  };
 
- Y_UNIT_TEST(EnableLocalDBBtreeIndex_Default) { // uses flat index
+ Y_UNIT_TEST(EnableLocalDBBtreeIndex_Default) { // uses b-tree index
  TMyEnvBase env;
  TRowsModel rows;
 
  auto &appData = env->GetAppData();
  UNIT_ASSERT_VALUES_EQUAL(appData.FeatureFlags.HasEnableLocalDBBtreeIndex(), false);
  UNIT_ASSERT_VALUES_EQUAL(appData.FeatureFlags.HasEnableLocalDBFlatIndex(), false);
- UNIT_ASSERT_VALUES_EQUAL(appData.FeatureFlags.GetEnableLocalDBBtreeIndex(), false);
+ UNIT_ASSERT_VALUES_EQUAL(appData.FeatureFlags.GetEnableLocalDBBtreeIndex(), true);
  UNIT_ASSERT_VALUES_EQUAL(appData.FeatureFlags.GetEnableLocalDBFlatIndex(), true);
  auto counters = GetSharedPageCounters(env);
  int readRows = 0, failedAttempts = 0;
@@ -6743,8 +6743,8 @@ Y_UNIT_TEST_SUITE(TFlatTableExecutor_BTreeIndex) {
  env.SendSync(new NFake::TEvCompact(TRowsModel::TableId));
  env.WaitFor<NFake::TEvCompacted>();
 
- // all pages are always kept in shared cache
- UNIT_ASSERT_VALUES_EQUAL(counters->ActivePages->Val(), 290);
+ // all pages are always kept in shared cache (except flat index)
+ UNIT_ASSERT_VALUES_EQUAL(counters->ActivePages->Val(), 334);
 
  env.SendSync(new NFake::TEvExecute{ new TTxFullScan(readRows, failedAttempts) });
  UNIT_ASSERT_VALUES_EQUAL(readRows, 1000);
@@ -6754,10 +6754,10 @@ Y_UNIT_TEST_SUITE(TFlatTableExecutor_BTreeIndex) {
  env.SendSync(new TEvents::TEvPoison, false, true);
  env.FireDummyTablet(ui32(NFake::TDummy::EFlg::Comp));
 
- // after restart we have no pages in private cache except flat index
+ // after restart we have no pages in private cache
  env.SendSync(new NFake::TEvExecute{ new TTxFullScan(readRows, failedAttempts) }, true);
  UNIT_ASSERT_VALUES_EQUAL(readRows, 1000);
- UNIT_ASSERT_VALUES_EQUAL(failedAttempts, 286);
+ UNIT_ASSERT_VALUES_EQUAL(failedAttempts, 330);
  }
 
  Y_UNIT_TEST(EnableLocalDBBtreeIndex_True) { // uses b-tree index