[Fix] react/jsx-no-bind Add props to example #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ljharb reviewed Feb 23, 2018
docs/rules/jsx-no-bind.md Outdated
| class Foo extends React.Component { | ||
| constructor() { | ||
| super(); | ||
| constructor(props) { |
There was a problem hiding this comment.
This isn't actually needed, and to be fully correct, it'd be props, context. It's a fine change tho.
There was a problem hiding this comment.
While not strictly necessary it allows use of this.props in the constructor and is suggested best practice by the React docs:
"Class components should always call the base constructor with props."
There was a problem hiding this comment.
In that case, what about constructor(...args) { super(...args); ? that way people copying the example will always forward all args.
There was a problem hiding this comment.
Comments addressed @ljharb. Anything else or are you happy to merge?
…e in the constructor.
ljharb approved these changes Mar 9, 2018
This was referenced May 12, 2018
ghost mentioned this pull request This was referenced Sep 22, 2018
Open
Closed
This was referenced Nov 23, 2018
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://reactjs.org/blog/2015/01/27/react-v0.13.0-beta-1.html#autobinding