Skip to content

Commit b1e2e05

Browse files
authored
github-actions: use slack and aws gh secrets (elastic#2065)
1 parent a0d334f commit b1e2e05

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,12 @@ jobs:
7474
needs:
7575
- build-distribution
7676
runs-on: ubuntu-latest
77+
env:
78+
# TODO: use keyless
79+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
80+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
7781
steps:
7882
- uses: actions/checkout@v4
79-
- uses: hashicorp/vault-action@v3.0.0
80-
with:
81-
url: ${{ secrets.VAULT_ADDR }}
82-
method: approle
83-
roleId: ${{ secrets.VAULT_ROLE_ID }}
84-
secretId: ${{ secrets.VAULT_SECRET_ID }}
85-
secrets: |
86-
secret/observability-team/ci/service-account/apm-agent-python access_key_id | AWS_ACCESS_KEY_ID ;
87-
secret/observability-team/ci/service-account/apm-agent-python secret_access_key | AWS_SECRET_ACCESS_KEY
8883
- uses: actions/download-artifact@v3
8984
with:
9085
name: build-distribution

.github/workflows/test.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,11 @@ jobs:
174174
needs: ${{ toJSON(needs) }}
175175
- run: ${{ steps.check.outputs.isSuccess }}
176176
- if: failure() && (github.event_name == 'schedule' || github.event_name == 'push')
177-
uses: elastic/apm-pipeline-library/.github/actions/notify-build-status@current
177+
uses: elastic/oblt-actions/slack/notify-result@v1
178178
with:
179+
bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
179180
status: ${{ steps.check.outputs.status }}
180-
vaultUrl: ${{ secrets.VAULT_ADDR }}
181-
vaultRoleId: ${{ secrets.VAULT_ROLE_ID }}
182-
vaultSecretId: ${{ secrets.VAULT_SECRET_ID }}
183-
slackChannel: "#apm-agent-python"
181+
channel-id: "#apm-agent-python"
184182

185183
coverage:
186184
name: Combine & check coverage.

0 commit comments

Comments
 (0)