Skip to content

Commit 78f03ce

Browse files
blauddendahlerlend
authored andcommitted
Bug#36679132
Unused goto and label for unsupported type For unsupported types the ndbcluster plugin utilizes an unusual goto which ends up in subsequent line. This is confusing. Remove goto and label. Return directly for not supported types. Change-Id: Ic9428d19c1238dd4261e6959d4e31088fdb9a92f
1 parent d71ae82 commit 78f03ce

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

storage/ndb/plugin/ha_ndbcluster.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8475,14 +8475,14 @@ static int create_ndb_column(THD *thd, NDBCOL &col, Field *field,
84758475
col.setLength(no_of_bits);
84768476
break;
84778477
}
8478-
case MYSQL_TYPE_NULL:
8479-
goto mysql_type_unsupported;
8478+
84808479
case MYSQL_TYPE_VECTOR:
84818480
push_warning_printf(
84828481
thd, Sql_condition::SL_WARNING, ER_UNSUPPORTED_EXTENSION,
84838482
"VECTOR type is not supported by NDB in this MySQL version");
84848483
return HA_ERR_UNSUPPORTED;
8485-
mysql_type_unsupported:
8484+
8485+
case MYSQL_TYPE_NULL:
84868486
default:
84878487
return HA_ERR_UNSUPPORTED;
84888488
}

0 commit comments

Comments
 (0)