- Notifications
You must be signed in to change notification settings - Fork 17
Introduce innovative method for widget highlighting #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we do an animated scroll, we'll have to make sure we scroll all scrolling parent containers. For example, what if a widget itself appears in a sidebar that is scrollable, but the preview window is also scrolled out of view? See #13 (comment) |
My concern with it being persistent is that it could get in the way of the user attempting to visualize how the widget will actually appear on the site. Maybe some users would get annoyed that the highlight is stuck on. /cc @shaunandrews |
| Sounds like something worth testing. My guess is that a persistent highlight will help more than it would hurt. Shaun
|
| Might seem a little bit corny, but I think an arrow pointing to the widget would be even better than a border change. Also think persistent is good, although a magnifying glass icon might work well to reduce the area that would cause the arrow to come up. |
| @shaunandrews it would be interesting to survey the different ways that widgets are oriented and rendered in a page. For example, sidebars can be oriented horizontally instead of vertically. The top row probably wouldn't work with a horizontal orientation. |
| @westonruter Very good point. What if we move the "edit flag" inside the widget, and make it slightly transparent: |
| @shaunandrews yes, that would work very well. The main problem then is figuring how when the edit flag should appear? If it persists then it would cover up the widget and would annoy someone trying to preview its contents, unless it is a very transparent (like |
| +1 to the edit flag or the "Custom Menu" flag with triangle. If you want the edit buttons to be persistent, how about a toggle in the Widget Customizer group allowing show/hide of widget edit overlays? |
| @shaunandrews proposes that we fade out the page outside of the review: |
| @shaunandrews I've applied your patch regarding the canvas widget highlighting to a separate branch, and I've turned this branch into a pull request for this issue. Further commits for the widget highlighting improvements can be done to this |
| Regarding the previous commit, see Skype convo from @shaunandrews:
|
| From Nacin in IRC:
|



Some improvements prompted by @shaunandrews:
Builds upon #13.
Depends on #56.