Skip to content

Conversation

@jasonbahl
Copy link
Contributor

What does this implement/fix? Explain your changes.

This fixes a bug where querying fields of the acfe_date_range_picker field type would return the following error when queried:

"DateTime::createFromFormat(): Argument #2 ($datetime) must be of type string, array given"

Does this close any currently open issues?

closes #163

Any other comments?

When querying a field of the acfe_date_range_picker type:

BEFORE

PHP Errors were being thrown:

CleanShot 2024-02-05 at 15 22 42

AFTER

No more errors:

CleanShot 2024-02-05 at 15 22 11

…ults of resolve_field - update test suites - Add test for querying the daterangepicker
@jasonbahl jasonbahl requested a review from josephfusco February 5, 2024 22:24
@jasonbahl jasonbahl self-assigned this Feb 5, 2024
@jasonbahl jasonbahl merged commit a0b2cdd into develop Feb 8, 2024
@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 2120cb25c7e08bdde8c612ee7fc40ee3bdc98c23-PR-166

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 62.492%

Totals Coverage Status
Change from base Build 42bab29b800d1bb012c6d360bc1e6871cff4ca49: 0.06%
Covered Lines: 2031
Relevant Lines: 3250

💛 - Coveralls
This was referenced Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants