-
- Notifications
You must be signed in to change notification settings - Fork 334
Flexible routines #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Flexible routines #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was only needed for the custom scrolling background / header that was removed some time ago
# Conflicts: # test/weight/weight_screen_test.mocks.dart
There are a lot of common steps that are always the same. This will specially important once we edit all the other configs and their max siblings
Also make sure that we don't update the routine while editing, since some of the changes could pull the rug under our feet and felt strange. Now there's a manual refresh button for the resulting routine
This is the same behaviour as in the web application is what most people most like will be doing anyway.
We always want to refresh the data since we don't update manually the dayData lists
b7b8aad to c2572b0 Compare This makes it look the same as the one to add new days and makes for a more consistent behaviour
c2572b0 to 58a641d Compare The date in which the routine was created is not so important anymore
The translations are not stored in a synthetic package anymore, but the files are just copied to a specific folder so it can be more easily imported Also, flutter_barcode_scanner was replaced by simple_barcode_scanner since the first hasn't been updated in 3 years and was already causing problems for some time
fdd56b0 to d071d14 Compare This is already available in gallery_form_test.dart
This will be filled in automatically by the backend
This wasn't describing properly how the rest days are being handled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Flutter changes for the flexible routines