Skip to content

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented Nov 26, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Remove webpack v4 support.

Breaking Changes

BREAKING CHANGE: minimum supported version of webpack is v5.0.0

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 91.99% // Head: 92.19% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (a354ca0) compared to base (5a71fb8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## next #4656 +/- ## ========================================== + Coverage 91.99% 92.19% +0.20%  ========================================== Files 16 15 -1 Lines 1661 1628 -33 Branches 623 611 -12 ========================================== - Hits 1528 1501 -27  + Misses 122 116 -6  Partials 11 11 
Impacted Files Coverage Δ
client-src/index.js 81.60% <ø> (-0.15%) ⬇️
lib/Server.js 93.84% <100.00%> (+0.16%) ⬆️
lib/servers/WebsocketServer.js 94.87% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

@snitin315 Can you rebase next?

@snitin315 snitin315 marked this pull request as ready for review November 27, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants