Skip to content

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 7, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Restore previously behavior (it is regression)

Breaking Changes

No

Additional Info

fixes #1991

@alexander-akait alexander-akait requested a review from hiroppy as a code owner June 7, 2019 12:57
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.13%.
The diff coverage is 90.9%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1993 +/- ## ========================================== - Coverage 92.65% 92.52% -0.14%  ========================================== Files 28 28 Lines 1075 1083 +8 Branches 323 324 +1 ========================================== + Hits 996 1002 +6  - Misses 75 77 +2  Partials 4 4
Impacted Files Coverage Δ
lib/utils/findPort.js 88.88% <90.9%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d901977...7c62c38. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing

@alexander-akait alexander-akait merged commit bc57514 into master Jun 7, 2019
@alexander-akait alexander-akait deleted the issue-1991 branch June 7, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants