refactor!: remove onAfterSetupMiddleware and onBeforeSetupMiddleware options (#4678)

Author: snitin315

lib/Server.js

@@ -198,8 +198,6 @@ const schema = require("./options.json");
  * @property {boolean} [setupExitSignals]
  * @property {boolean | ClientConfiguration} [client]
  * @property {Headers | ((req: Request, res: Response, context: DevMiddlewareContext<Request, Response>) => Headers)} [headers]
- * @property {(devServer: Server) => void} [onAfterSetupMiddleware]
- * @property {(devServer: Server) => void} [onBeforeSetupMiddleware]
  * @property {(devServer: Server) => void} [onListening]
  * @property {(middlewares: Middleware[], devServer: Server) => Middleware[]} [setupMiddlewares]
  */
@@ -1259,24 +1257,6 @@ class Server {
  (options.open) = [...getOpenItemsFromObject(options.open)];
  }
 
- if (options.onAfterSetupMiddleware) {
- // TODO: remove in the next major release
- util.deprecate(
- () => {},
- "'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.",
- `DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE`
- )();
- }
-
- if (options.onBeforeSetupMiddleware) {
- // TODO: remove in the next major release
- util.deprecate(
- () => {},
- "'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.",
- `DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE`
- )();
- }
-
  if (typeof options.port === "string" && options.port !== "auto") {
  options.port = Number(options.port);
  }
@@ -2022,10 +2002,6 @@ class Server {
  middlewares.push({ name: "compression", middleware: compression() });
  }
 
- if (typeof this.options.onBeforeSetupMiddleware === "function") {
- this.options.onBeforeSetupMiddleware(this);
- }
-
  if (typeof this.options.headers !== "undefined") {
  middlewares.push({
  name: "set-headers",
@@ -2326,10 +2302,6 @@ class Server {
  (this.app).use(middleware.middleware);
  }
  });
-
- if (typeof this.options.onAfterSetupMiddleware === "function") {
- this.options.onAfterSetupMiddleware(this);
- }
  }
 
  /**

lib/options.json

@@ -351,16 +351,6 @@
  },
  "link": "https://webpack.js.org/configuration/dev-server/#devservermagichtml"
  },
- "OnAfterSetupMiddleware": {
- "instanceof": "Function",
- "description": "Provides the ability to execute a custom function and apply custom middleware(s) after all other middlewares. Deprecated: please use the 'setupMiddlewares' option.",
- "link": "https://webpack.js.org/configuration/dev-server/#devserveronaftersetupmiddleware"
- },
- "OnBeforeSetupMiddleware": {
- "instanceof": "Function",
- "description": "Provides the ability to execute a custom function and apply custom middleware(s) prior to all other middlewares. Deprecated: please use the 'setupMiddlewares' option.",
- "link": "https://webpack.js.org/configuration/dev-server/#devserveronbeforesetupmiddleware"
- },
  "OnListening": {
  "instanceof": "Function",
  "description": "Provides the ability to execute a custom function when dev server starts listening.",
@@ -983,12 +973,6 @@
  "magicHtml": {
  "$ref": "#/definitions/MagicHTML"
  },
- "onAfterSetupMiddleware": {
- "$ref": "#/definitions/OnAfterSetupMiddleware"
- },
- "onBeforeSetupMiddleware": {
- "$ref": "#/definitions/OnBeforeSetupMiddleware"
- },
  "onListening": {
  "$ref": "#/definitions/OnListening"
  },

test/__snapshots__/validate-options.test.js.snap.webpack5

@@ -382,20 +382,6 @@ exports[`options validate should throw an error on the "magicHtml" option with '
  -> Read more at https://webpack.js.org/configuration/dev-server/#devservermagichtml"
 `;
 
-exports[`options validate should throw an error on the "onAfterSetupMiddleware" option with 'false' value 1`] = `
-"ValidationError: Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
- - options.onAfterSetupMiddleware should be an instance of function.
- -> Provides the ability to execute a custom function and apply custom middleware(s) after all other middlewares. Deprecated: please use the 'setupMiddlewares' option.
- -> Read more at https://webpack.js.org/configuration/dev-server/#devserveronaftersetupmiddleware"
-`;
-
-exports[`options validate should throw an error on the "onBeforeSetupMiddleware" option with 'false' value 1`] = `
-"ValidationError: Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
- - options.onBeforeSetupMiddleware should be an instance of function.
- -> Provides the ability to execute a custom function and apply custom middleware(s) prior to all other middlewares. Deprecated: please use the 'setupMiddlewares' option.
- -> Read more at https://webpack.js.org/configuration/dev-server/#devserveronbeforesetupmiddleware"
-`;
-
 exports[`options validate should throw an error on the "onListening" option with '' value 1`] = `
 "ValidationError: Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
  - options.onListening should be an instance of function.