fix: set WEBPACK_SERVE to string value 'true' (string) (#4718)

Author: snitin315

lib/Server.js

@@ -205,9 +205,7 @@ const schema = require("./options.json");
  */
 
 if (!process.env.WEBPACK_SERVE) {
- // TODO fix me in the next major release
- // @ts-ignore
- process.env.WEBPACK_SERVE = true;
+ process.env.WEBPACK_SERVE = "true";
 }
 
 /**

test/e2e/api.test.js

@@ -55,7 +55,7 @@ describe("API", () => {
 
  await server.start();
 
- expect(process.env.WEBPACK_SERVE).toBe(true);
+ expect(process.env.WEBPACK_SERVE).toBe("true");
 
  const response = await page.goto(`http://127.0.0.1:${port}/`, {
  waitUntil: "networkidle0",

types/lib/Server.d.ts

@@ -721,10 +721,6 @@ declare class Server {
  description: string;
  link: string;
  };
- /**
- * @private
- * @type {RequestHandler[]}
- */
  HistoryApiFallback: {
  anyOf: (
  | {
@@ -742,11 +738,6 @@ declare class Server {
  cli?: undefined;
  }
  )[];
- /**
- * @private
- * @returns {StatsOptions}
- * @constructor
- */
  description: string;
  link: string;
  };
@@ -766,10 +757,6 @@ declare class Server {
  }
  )[];
  };
- /**
- * @param {string} gateway
- * @returns {string | undefined}
- */
  Hot: {
  anyOf: (
  | {
@@ -845,9 +832,6 @@ declare class Server {
  description: string;
  link: string;
  };
- /**
- * @returns {string}
- */
  OpenBoolean: {
  type: string;
  cli: {
@@ -957,6 +941,7 @@ declare class Server {
  };
  Proxy: {
  type: string;
+ /** @type {WebSocketURL} */
  items: {
  anyOf: (
  | {
@@ -992,7 +977,7 @@ declare class Server {
  type: string;
  minLength: number;
  cli: {
- exclude: boolean;
+ exclude: boolean /** @type {string} */;
  };
  };
  ServerObject: {
@@ -1236,7 +1221,7 @@ declare class Server {
  }
  )[];
  description: string;
- /** @type {MultiCompiler} */ link: string;
+ link: string;
  };
  StaticObject: {
  type: string;
@@ -1271,10 +1256,6 @@ declare class Server {
  description: string;
  link: string;
  };
- /**
- * @private
- * @returns {Promise<void>}
- */
  serveIndex: {
  anyOf: (
  | {