feat: add globalObject option to modify global context #205
Conversation
| @alexander-akait Brand new PR. Maybe this will work. |
| Weird, I really don't undestand why bot doesn't work, because it works for any other repos and PRs |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #205 +/- ## ========================================== + Coverage 82.01% 82.26% +0.25% ========================================== Files 4 4 Lines 139 141 +2 Branches 49 51 +2 ========================================== + Hits 114 116 +2 Misses 16 16 Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| Give me some times I will write report about it and we will fix it soon (today) |
| Plese use link directly - https://easycla.lfx.linuxfoundation.org/#/?version=2 and accept CLA, thank you and sorry again |
| Doesn't seem to have a place to lookup the CLA. |
| Can you try to remove signature from your commit, maybe github doesn't like such commits and don't run bots on it, look at the commit message and next to it you will see |
mabounassif force-pushed the global_object branch from 449008c to 868a421 Compare 
|
|
| That was it! |
| Thank you I will do release right now |
2 participants
This PR contains a:
Motivation / Use-Case
There are custom JS engines out there that seal the
globalThisobject. By default, this will break the assignment of the object we want to make global into the global context.This PR gives the power to the user to override the default and choose the global object of their choosing.
Breaking Changes
There should be no breaking changes.
Additional Info
Addresses #203