Add subgroups feature #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been standardized in the JS API, so we can add it now. Small breaking change by adding items to WGPUAdapterInfo, but these items can always be populated, in the same way they are in JS. Fixes 428
Collaborator Author
| @dneto0 PTAL |
Collaborator Author
| @cwfitzgerald this is just matching the JS spec so I assume it's fine, but let me know if not |
cwfitzgerald approved these changes Jan 31, 2025
copybara-service bot pushed a commit to google/dawn that referenced this pull request Feb 4, 2025
Spec PR: webgpu-native/webgpu-headers#509 Change-Id: I5510a054304d802dfbcbfe1a03ef8f2e6db36032 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/223876 Reviewed-by: Alan Baker <alanbaker@google.com> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
copybara-service bot pushed a commit to google/dawn that referenced this pull request Feb 4, 2025
Spec PR: webgpu-native/webgpu-headers#509 Change-Id: I06e44901a363aca4903a3b5c577a6692b97f34f2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/224214 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This has been standardized in the JS API, so we can add it now.
Small breaking change by adding items to WGPUAdapterInfo, but these items can always be populated, in the same way they are in JS, so they don't need to be in an extension struct.
Fixes #428