HTML parser: Fix parser to close the p tag #13449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
According to spec, if the start tag is a dialog tag and the stack of open elements has a p element in button scope then closes a p element. Also if the end tag is a dialog tag and the stack of close elements have a p element in button scope, then it should close a p element. reference: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody html5lib-tests PR: html5lib/html5lib-tests#91 Bug: 704534 Change-Id: I5b90243eda3dfca7b14bf53c5767af65fc2b7dc5
wpt-pr-bot approved these changes Oct 10, 2018
Collaborator
wpt-pr-bot left a comment
wpt-pr-bot left a comment There was a problem hiding this comment.
Already reviewed downstream.
Collaborator Author
| Close this PR because the Chromium CL has been abandoned. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
According to spec, if the start tag is a dialog tag
and the stack of open elements has a p element in
button scope then closes a p element.
Also if the end tag is a dialog tag and the stack of
close elements have a p element in button scope,
then it should close a p element.
reference:
https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody
html5lib-tests PR:
html5lib/html5lib-tests#91
Bug: 704534
Change-Id: I5b90243eda3dfca7b14bf53c5767af65fc2b7dc5
Reviewed-on: https://chromium-review.googlesource.com/1270699
WPT-Export-Revision: fac679680cf8a263bd41e9ee63d7f7f124c23551