chore: rename rsbuildConfig to config #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Timeless0911 approved these changes Nov 4, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API call to Rsbuild's createRsbuild function to align with a breaking change in @rsbuild/core, where the parameter property name changed from rsbuildConfig to config.
Key Changes:
- Updated all
createRsbuildcalls fromrsbuildConfigtoconfigproperty - Updated test utilities to use the new
configproperty name - Reformatted one line in test utilities for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/cli/build.ts | Updated createRsbuild parameter from rsbuildConfig to config |
| packages/core/src/cli/inspect.ts | Updated createRsbuild parameter from rsbuildConfig to config |
| packages/core/src/cli/mf.ts | Updated createRsbuild parameter from rsbuildConfig to config |
| tests/scripts/rsbuild.ts | Updated test utilities to use config instead of rsbuildConfig and reformatted config assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the configuration parameter name of
createRsbuild, see web-infra-dev/rsbuild#6245Checklist