Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 5, 2025

Summary

This PR is used to test the native HTML implementation, ensuring that all E2E cases can be passed.

Diff

Breaking changes

  • <%= process.env.ASSET_PREFIX %> is no longer supported, use <%= assetPrefix %> instead

Non-breaking changes

  • The order of the tag attributes has changed

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
Copilot AI review requested due to automatic review settings November 5, 2025 08:33
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 46556af
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/690b1d52e29a7b0008e949cf
😎 Deploy Preview https://deploy-preview-6505--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan marked this pull request as draft November 5, 2025 08:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the default HTML plugin implementation from JavaScript-based ('js') to Rust-based native implementation ('native'). The native implementation produces HTML link tags with a different attribute ordering, placing the href attribute before the rel attribute. All test expectations have been updated to match this new attribute order.

Key Changes

  • Changed default html.implementation from 'js' to 'native' in the core configuration
  • Updated all HTML link tag assertions in e2e tests to expect the new attribute order (href before rel)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/defaultConfig.ts Changed default HTML implementation from 'js' to 'native'
e2e/cases/html/favicon/index.test.ts Updated test expectations for favicon link tags to match new attribute order
e2e/cases/html/app-icon/index.test.ts Updated test expectations for app icon and manifest link tags to match new attribute order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

outputStructure: 'flat',
scriptLoading: 'defer',
implementation: 'js',
implementation: 'native',
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the default from 'js' to 'native' is a significant breaking change that affects HTML output format. The documentation at line 1605 in types/config.ts states '@default 'js'' which should be updated to reflect this new default value of 'native'.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants