Skip to content

Commit cf6b265

Browse files
committed
Fixed several part
1 parent a93dcc0 commit cf6b265

File tree

10 files changed

+36
-37
lines changed

10 files changed

+36
-37
lines changed

Example1/AudioStreamer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ private void configure()
108108

109109
_ws.OnError += (sender, e) =>
110110
{
111-
enNfMessage("[AudioStreamer] error", "WS Error: " + e.Data, "notification-message-im");
111+
enNfMessage("[AudioStreamer] error", "WS: Error: " + e.Data, "notification-message-im");
112112
};
113113

114114
_ws.OnClose += (sender, e) =>
115115
{
116116
enNfMessage
117117
(
118118
"[AudioStreamer] disconnect",
119-
String.Format("WS Close({0}:{1}): {2}", (ushort)e.Code, e.Code, e.Reason),
119+
String.Format("WS: Close({0}:{1}): {2}", (ushort)e.Code, e.Code, e.Reason),
120120
"notification-message-im"
121121
);
122122
};

websocket-sharp.userprefs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<MonoDevelop.Ide.Workspace ActiveConfiguration="Release_Ubuntu" />
33
<MonoDevelop.Ide.Workbench ActiveDocument="websocket-sharp/WebSocket.cs">
44
<Files>
5-
<File FileName="websocket-sharp/WebSocket.cs" Line="217" Column="41" />
5+
<File FileName="websocket-sharp/WebSocket.cs" Line="428" Column="39" />
66
</Files>
77
</MonoDevelop.Ide.Workbench>
88
<MonoDevelop.Ide.DebuggingService.Breakpoints>

websocket-sharp/Ext.cs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,25 @@ namespace WebSocketSharp
3636
{
3737
public static class Ext
3838
{
39+
public static void Emit(
40+
this EventHandler eventHandler, object sender, EventArgs e)
41+
{
42+
if (eventHandler != null)
43+
{
44+
eventHandler(sender, e);
45+
}
46+
}
47+
48+
public static void Emit<TEventArgs>(
49+
this EventHandler<TEventArgs> eventHandler, object sender, TEventArgs e)
50+
where TEventArgs : EventArgs
51+
{
52+
if (eventHandler != null)
53+
{
54+
eventHandler(sender, e);
55+
}
56+
}
57+
3958
public static bool EqualsAndSaveTo(this int value, char c, List<byte> dest)
4059
{
4160
byte b = (byte)value;

websocket-sharp/Frame/PayloadData.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public class PayloadData : IEnumerable<byte>
4747

4848
public byte[] ExtensionData { get; private set; }
4949
public byte[] ApplicationData { get; private set; }
50-
public bool IsMasked { get; private set; }
50+
51+
public bool IsMasked { get; private set; }
5152

5253
public ulong Length
5354
{
@@ -154,6 +155,7 @@ public void Mask(byte[] maskingKey)
154155
{
155156
mask(ExtensionData, maskingKey);
156157
}
158+
157159
if (ApplicationData.LongLength > 0)
158160
{
159161
mask(ApplicationData, maskingKey);

websocket-sharp/WebSocket.cs

Lines changed: 11 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,7 @@ private set
126126
{
127127
case WsState.OPEN:
128128
messageThreadStart();
129-
if (OnOpen != null)
130-
{
131-
OnOpen(this, EventArgs.Empty);
132-
}
129+
OnOpen.Emit(this, EventArgs.Empty);
133130
break;
134131
case WsState.CLOSING:
135132
break;
@@ -229,14 +226,14 @@ private void close(PayloadData data)
229226
else if (_readyState == WsState.CONNECTING)
230227
{
231228
ReadyState = WsState.CLOSED;
232-
emitOnClose(data);
229+
OnClose.Emit(this, new CloseEventArgs(data));
233230
return;
234231
}
235232

236233
ReadyState = WsState.CLOSING;
237234
}
238235

239-
emitOnClose(data);
236+
OnClose.Emit(this, new CloseEventArgs(data));
240237
var frame = new WsFrame(Opcode.CLOSE, data);
241238
closeHandshake(frame);
242239
#if DEBUG
@@ -428,27 +425,14 @@ private void doHandshake()
428425
ReadyState = WsState.OPEN;
429426
}
430427

431-
private void emitOnClose(PayloadData data)
432-
{
433-
if (OnClose != null)
434-
{
435-
OnClose(this, new CloseEventArgs(data));
436-
}
437-
}
438-
439428
private void error(string message)
440429
{
430+
#if DEBUG
441431
var callerFrame = new StackFrame(1);
442432
var caller = callerFrame.GetMethod();
443-
444-
if (OnError != null)
445-
{
446-
OnError(this, new MessageEventArgs(message));
447-
}
448-
else
449-
{
450-
Console.WriteLine("WS: Error@{0}: {1}", caller.Name, message);
451-
}
433+
Console.WriteLine("WS: Error@{0}: {1}", caller.Name, message);
434+
#endif
435+
OnError.Emit(this, new MessageEventArgs(message));
452436
}
453437

454438
private bool isValidResponse(string[] response, out string message)
@@ -548,9 +532,9 @@ private void message()
548532
{
549533
eventArgs = receive();
550534

551-
if (OnMessage != null && eventArgs != null)
535+
if (eventArgs != null)
552536
{
553-
OnMessage(this, eventArgs);
537+
OnMessage.Emit(this, eventArgs);
554538
}
555539
}
556540
catch (WsReceivedTooBigMessageException ex)
@@ -630,17 +614,11 @@ private MessageEventArgs receive()
630614
else if (frame.Opcode == Opcode.PING)
631615
{// FINAL & PING
632616
pong(frame.PayloadData);
633-
if (OnMessage != null)
634-
{
635-
OnMessage(this, new MessageEventArgs(frame.Opcode, frame.PayloadData));
636-
}
617+
OnMessage.Emit(this, new MessageEventArgs(frame.Opcode, frame.PayloadData));
637618
}
638619
else if (frame.Opcode == Opcode.PONG)
639620
{// FINAL & PONG
640-
if (OnMessage != null)
641-
{
642-
OnMessage(this, new MessageEventArgs(frame.Opcode, frame.PayloadData));
643-
}
621+
OnMessage.Emit(this, new MessageEventArgs(frame.Opcode, frame.PayloadData));
644622
}
645623
else
646624
{// FINAL & (TEXT | BINARY)
512 Bytes
Binary file not shown.
0 Bytes
Binary file not shown.
-512 Bytes
Binary file not shown.
-512 Bytes
Binary file not shown.
214 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)