Skip to content

Conversation

@tkent-google
Copy link
Contributor

Chromium project has 90 seconds limit for each of test run with Debug
build. Range-mutations.html was too slow, and exceeded the limit.

@wpt-pr-bot
Copy link
Collaborator

Reviewers for this pull request are: @Ms2ger, @ayg, @jdm, @plehegar, @zcorpan, and @zqzhang.

@tkent-google
Copy link
Contributor Author

It seems Travis failed because console output were too long.

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

@youennf
Copy link
Contributor

youennf commented Oct 21, 2016

@tkent-google, I am in general in favour of splitting tests. This fits better with WebKit (and it seems Chrome as well) test infrastructure.

We had similar issues in WebKit with slow tests.
We upgraded the W3C test parser script to check for the timeout meta tag.
We upgraded the W3C test importer script to mark these tests as slow in a dedicated test-options.json file. The test timeout limit is increased for those tests.

Chromium project has 90 seconds limit for each of test run with Debug build. Range-mutations.html was too slow, and exceeded the limit.
@tkent-google tkent-google force-pushed the tkent-split-range-mutations branch from 9ffd978 to b2b803e Compare October 24, 2016 01:45
@jgraham
Copy link
Contributor

jgraham commented Oct 24, 2016

Please rebase to trigger a fixed travis script. Once that's done r+ from me.

@tkent-google
Copy link
Contributor Author

All checks passed and this PR is now mergeable, however ci_stability.sh threw an exception.

https://travis-ci.org/w3c/web-platform-tests/jobs/170283476

ERROR:check_stability:Traceback (most recent call last): File "check_stability.py", line 557, in main gh_handler.send() File "check_stability.py", line 141, in send self.github.post_comment(self.pull_number, "\n".join(self.log_data)) File "check_stability.py", line 119, in post_comment return self.post(url, {"body": body}) File "check_stability.py", line 104, in post resp.raise_for_status() File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/requests/models.py", line 862, in raise_for_status raise HTTPError(http_error_msg, response=self) HTTPError: 422 Client Error: Unprocessable Entity for url: https://api.github.com/repos/w3c/web-platform-tests/issues/4049/comments 
@tkent-google tkent-google merged commit 1443705 into master Oct 24, 2016
@tkent-google tkent-google deleted the tkent-split-range-mutations branch October 24, 2016 23:38
tkent-google added a commit that referenced this pull request Jan 18, 2017
addRange.html exceeds the time limit for a single test in Chromium project, and also the text dump of its result exceeds the file size limit of code review tool of Chromium project. This is similar to #4049
sideshowbarker pushed a commit that referenced this pull request Jan 18, 2017
* selection: Split addRange.html into 15. addRange.html exceeds the time limit for a single test in Chromium project, and also the text dump of its result exceeds the file size limit of code review tool of Chromium project. This is similar to #4049 * Add a comment to testAddRangeSubSet().
tkent-google added a commit that referenced this pull request Jan 19, 2017
The text dump of collapse.html and extend.html result exceed the file size limit in Chromium project. This is similar to: #4049 #4549
TakayoshiKochi pushed a commit that referenced this pull request Jan 19, 2017
* selection: Split collapse.html into 2, and extend.html into 3. The text dump of collapse.html and extend.html result exceed the file size limit in Chromium project. This is similar to: #4049 #4549 * Add comments to common.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants