Ensure "race-network-and-fetch-handler" is used with a fetch handler #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As covered in https://github.com/WICG/service-worker-static-routing-api?tab=readme-ov-file#how-does-it-work-if-there-is-no-fetch-handler, the fetch handler must exists not only for the "fetch-handler" source but also the "race-network-and-fetch-handler" source. The "race-network-and-fetch-handler" source was not written in the last update.
Collaborator Author
| @domenic @mkruisselbrink Will you take a look? Thank you. |
domenic approved these changes Jun 5, 2024
Collaborator Author
| Thanks Domenic for the review. |
Collaborator Author
| I think this is a simple spec mistake on the previous edit. Since race-network-and-fetch-handler also depends on the fetch event, having the handler should also be ensured. |
Collaborator Author
| Since the race-network-and-fetch-event source in ServiceWorker static routing API does competition on network and fetch handler, this PR asks the fetch handler to exist on using the source. |
monica-ch approved these changes Jan 28, 2025
github-actions bot added a commit that referenced this pull request Jan 28, 2025
SHA: a14460b Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request Jan 28, 2025
SHA: a14460b Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 29, 2025
This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 29, 2025
This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 29, 2025
This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 31, 2025
…dler source without handler, a=testonly Automatic update from web-platform-tests Raise for the race-network-and-fetch-handler source without handler This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763} -- wpt-commits: dcdc147a9ad20ccdef156d4444fbf526a2380235 wpt-pr: 50363
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Feb 5, 2025
…dler source without handler, a=testonly Automatic update from web-platform-tests Raise for the race-network-and-fetch-handler source without handler This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763} -- wpt-commits: dcdc147a9ad20ccdef156d4444fbf526a2380235 wpt-pr: 50363
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…dler source without handler, a=testonly Automatic update from web-platform-tests Raise for the race-network-and-fetch-handler source without handler This reflects the change in w3c/ServiceWorker#1719. Instead of silently fallback to network, let me make `addRoutes()` raise if the race-network-and-fetch-handler source is used without having a fetch handler. Fixed: 391990601 Change-Id: Ic944e183286cd056235b0fe272c543533dfaa86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211317 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412763} -- wpt-commits: dcdc147a9ad20ccdef156d4444fbf526a2380235 wpt-pr: 50363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As covered in https://github.com/WICG/service-worker-static-routing-api?tab=readme-ov-file#how-does-it-work-if-there-is-no-fetch-handler, the fetch handler must exists not only for the "fetch-handler" source but also the "race-network-and-fetch-handler" source. The "race-network-and-fetch-handler" source was not written in the last update.
Preview | Diff