Skip to content

(Fix #1261) Don't emit input directly in MdInput and MdTextarea #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcosmoura merged 2 commits into from
Dec 22, 2017
Merged

(Fix #1261) Don't emit input directly in MdInput and MdTextarea #1285

marcosmoura merged 2 commits into from
Dec 22, 2017

Conversation

@korylprince
Copy link
Contributor

@korylprince korylprince commented Dec 8, 2017

Fixes #1261.

Notes: use Object.assign to deep copy this.$listeners. delete input key as opposed to setting to undefined which causes error.
marcosmoura
marcosmoura requested changes Dec 19, 2017
View reviewed changes
src/components/MdField/MdTextarea/MdTextarea.vue Outdated
...this.$listeners,
input: event => this.$emit('input', event.target.value)
}
var l = Object.assign({}, this.$listeners)
Copy link
Member

@marcosmoura marcosmoura Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.assign is not available for all browsers.
@korylprince
Copy link
Contributor Author

korylprince commented Dec 19, 2017

Sorry! I thought Object.assign was transformed by babel. I've changed it over to the spread operator which is transformed by your babel config.
@marcosmoura marcosmoura merged commit 00832e9 into vuematerial:dev Dec 22, 2017
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@korylprince @marcosmoura