Skip to content

fix(templateRef): set ref on cached async component which wrapped in KeepAlive #12290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix(templateRef): set ref on cached async component which wrapped in KeepAlive #12290

merged 4 commits into from
Nov 15, 2024
+79 −3

Conversation

edison1105
Copy link
Member

close #4999
close #5004
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+103 B) 37.9 kB (+20 B) 34.2 kB (+16 B)
vue.global.prod.js 158 kB (+103 B) 57.8 kB (+19 B) 51.4 kB (+104 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB (+103 B) 18.3 kB (+18 B) 16.8 kB (-35 B)
createApp 55.2 kB (+103 B) 21.3 kB (+20 B) 19.5 kB (+14 B)
createSSRApp 59.3 kB (+103 B) 23.1 kB (+15 B) 21 kB (+27 B)
defineCustomElement 60.1 kB (+103 B) 22.9 kB (+27 B) 20.9 kB (+14 B)
overall 69.1 kB (+103 B) 26.5 kB (+23 B) 24 kB (-37 B)
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 29, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12290

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12290

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12290

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12290

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12290

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12290

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12290

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12290

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12290

vue

pnpm add https://pkg.pr.new/vue@12290

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12290

commit: 26930ca
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Oct 30, 2024
@edison1105 edison1105 changed the title fix(templateRef): set ref on async component which wrapped in KeepAlive fix(templateRef): set ref on cached async component which wrapped in KeepAlive Oct 30, 2024
@yyx990803 yyx990803 merged commit 983eb50 into main Nov 15, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/4999 branch November 15, 2024 14:32
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
@edison1105 @abdullah-wn
fix(templateRef): set ref on cached async component which wrapped in …
7ec0db0 
…KeepAlive (vuejs#12290) close vuejs#4999 close vuejs#5004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
2 participants
@edison1105 @yyx990803