fix: add exitentions to esm package (COR-9112) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR adds tsc-alias configuration to the ESM build configuration for the slate-serializer library to ensure TypeScript path aliases are properly resolved to their full paths during the build process.
- Added
tsc-aliasconfiguration block withresolveFullPaths: truetotsconfig.build.esm.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
tsc-aliasconfiguration withresolveFullPathsset to true in the ESM build configuration.What changed?
Added a
tsc-aliasconfiguration object to thetsconfig.build.esm.jsonfile with theresolveFullPathsproperty set totrue. This ensures that path aliases are properly resolved when building the ESM version of the slate-serializer library.How to test?
yarn buildWhy make this change?
The
resolveFullPathsoption fortsc-aliasensures that TypeScript path aliases are correctly resolved to their full paths during the ESM build process. This prevents potential module resolution issues when the library is consumed by other projects, especially in ESM environments where path resolution can be more strict.