Skip to content

Conversation

@the-codeboy
Copy link
Contributor

@the-codeboy the-codeboy commented Nov 11, 2025

Purpose

Fixed two typos in the serving docs about the open ai compatible api

Test Plan

Didn't change any content, just two typos:
how are roles, messages, and other chat-specific tokens are encoded in the input -> how roles, messages, and other chat-specific tokens are encoded in the input
For those model -> For those models

Test Result

everything still works since i only fixed typos


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.
Signed-off-by: the-codeboy <71213855+the-codeboy@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify
Copy link

mergify bot commented Nov 11, 2025

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes two minor typos in the openai_compatible_server.md documentation file. The changes are correct and improve the clarity of the text. The PR is well-scoped and ready to be merged.

Copy link
Collaborator

@tjtanaa tjtanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-codeboy LGTM. Thank you for proof reading.

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 11, 2025
@tjtanaa tjtanaa enabled auto-merge (squash) November 11, 2025 16:44
@tjtanaa tjtanaa merged commit 287bbbe into vllm-project:main Nov 11, 2025
12 checks passed
fangyuchu pushed a commit to fangyuchu/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: the-codeboy <71213855+the-codeboy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

2 participants