-
- Notifications
You must be signed in to change notification settings - Fork 11.2k
[doc] fix multimodal example script #18089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
ywang96 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment - PTAL!
examples/online_serving/openai_chat_completion_client_for_multimodal.py Outdated Show resolved Hide resolved
davidxia left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to a separate util file
sgtm, I moved to model_utils.py. Lmk if that name works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add --trust-remote-code otherwise the model wasn't downloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add cmd to run so user doesn't have to figure it out
e368de4 to d94df82 Compare | Are the test failures related to my changes? |
No, merging from main should fix the issue |
We can't run the script with `--help` to see the help message without connecting to a running vLLM server. This change allows us to do that. We also improve the error message when the script cannot get a list of models from vLLM. Signed-off-by: David Xia <david@davidxia.com>
Signed-off-by: David Xia <david@davidxia.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
We can't run the script with
--helpto see the help message without connecting to a running vLLM server. This change allows us to do that.We also improve the error message when the script cannot get a list of models
from vLLM.
before
after