fix: add missing awaits (#20697)

Author: sapphi-red

packages/vite/src/node/__tests__/dev.spec.ts

@@ -24,8 +24,8 @@ describe('resolveBuildEnvironmentOptions in dev', () => {
 describe('the dev server', () => {
  let server: ViteDevServer
 
- afterEach(() => {
- server?.close()
+ afterEach(async () => {
+ await server?.close()
  })
 
  test('resolves the server URLs before the httpServer listening events are called', async () => {

packages/vite/src/node/cli.ts

@@ -278,7 +278,7 @@ cli
  logger.error(colors.red(`error when starting dev server:\n${e.stack}`), {
  error: e,
  })
- stopProfiler(logger.info)
+ await stopProfiler(logger.info)
  process.exit(1)
  }
  })
@@ -353,7 +353,9 @@ cli
  )
  process.exit(1)
  } finally {
- stopProfiler((message) => createLogger(options.logLevel).info(message))
+ await stopProfiler((message) =>
+ createLogger(options.logLevel).info(message),
+ )
  }
  },
  )
@@ -444,7 +446,9 @@ cli
  )
  process.exit(1)
  } finally {
- stopProfiler((message) => createLogger(options.logLevel).info(message))
+ await stopProfiler((message) =>
+ createLogger(options.logLevel).info(message),
+ )
  }
  },
  )

packages/vite/src/node/plugins/css.ts

@@ -2481,7 +2481,8 @@ const makeScssWorker = (
  } satisfies ScssWorkerResult
  },
  async stop() {
- ;(await compilerPromise)?.dispose()
+ const compiler = await compilerPromise
+ await compiler?.dispose()
  compilerPromise = undefined
  },
  }

packages/vite/src/node/ssr/__tests__/ssrLoadModule.spec.ts

@@ -17,7 +17,7 @@ async function createDevServer() {
  noDiscovery: true,
  },
  })
- server.environments.ssr.pluginContainer.buildStart({})
+ await server.environments.ssr.pluginContainer.buildStart({})
  return server
 }
 
@@ -93,7 +93,7 @@ test('virtual module invalidation simple', async () => {
  },
  ],
  })
- server.environments.ssr.pluginContainer.buildStart({})
+ await server.environments.ssr.pluginContainer.buildStart({})
 
  const mod1 = await server.ssrLoadModule('virtual:test')
  expect(mod1.default).toEqual(1)
@@ -151,7 +151,7 @@ test('virtual module invalidation nested', async () => {
  },
  ],
  })
- server.environments.ssr.pluginContainer.buildStart({})
+ await server.environments.ssr.pluginContainer.buildStart({})
 
  const mod1 = await server.ssrLoadModule('virtual:test')
  expect(mod1.default).toEqual(1)

packages/vite/src/node/ssr/__tests__/ssrStacktrace.spec.ts

@@ -13,7 +13,7 @@ async function createDevServer() {
  noDiscovery: true,
  },
  })
- server.environments.ssr.pluginContainer.buildStart({})
+ await server.environments.ssr.pluginContainer.buildStart({})
  return server
 }
 

packages/vite/src/node/ssr/runtime/__tests__/server-worker-runner.invoke.spec.ts

@@ -59,9 +59,8 @@ describe('running module runner inside a worker and using the ModuleRunnerTransp
  )
  })
 
- afterAll(() => {
- server.close()
- worker.terminate()
+ afterAll(async () => {
+ await Promise.allSettled([server.close(), worker.terminate()])
  rpc.$close()
  })
 

packages/vite/src/node/ssr/runtime/__tests__/server-worker-runner.spec.ts

@@ -75,9 +75,8 @@ describe('running module runner inside a worker', () => {
  },
  },
  })
- onTestFinished(() => {
- server.close()
- worker.terminate()
+ onTestFinished(async () => {
+ await Promise.allSettled([server.close(), worker.terminate()])
  })
  const channel = new BroadcastChannel('vite-worker')
  return new Promise<void>((resolve, reject) => {