[Java] Fix up issues and discoveries found from PR aeron-io#319.

Author: mjpt777

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStub.java

@@ -47,7 +47,7 @@ public class ExampleUsingGeneratedStub
  MANUFACTURER_CODE = "123".getBytes(EngineEncoder.manufacturerCodeCharacterEncoding());
  MAKE = "Honda".getBytes(CarEncoder.makeCharacterEncoding());
  MODEL = "Civic VTi".getBytes(CarEncoder.modelCharacterEncoding());
- ACTIVATION_CODE = new UnsafeBuffer(ByteBuffer.wrap(new byte[]{'d', 'e', 'a', 'd', 'b', 'e', 'e', 'f'}));
+ ACTIVATION_CODE = new UnsafeBuffer("abcdef".getBytes(CarEncoder.activationCodeCharacterEncoding()));
  }
  catch (final UnsupportedEncodingException ex)
  {
@@ -240,7 +240,8 @@ public static void decode(
 
  final UnsafeBuffer tempBuffer = new UnsafeBuffer(buffer);
  final int tempBufferLength = car.getActivationCode(tempBuffer, 0, tempBuffer.capacity());
- sb.append("\ncar.activationCode=").append(new String(buffer, 0, tempBufferLength, Charset.forName("UTF-8")));
+ sb.append("\ncar.activationCode=").append(
+ new String(buffer, 0, tempBufferLength, CarEncoder.activationCodeCharacterEncoding()));
 
  sb.append("\ncar.encodedLength=").append(car.encodedLength());
 

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStubExtension.java

@@ -22,7 +22,6 @@
 import java.io.UnsupportedEncodingException;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
-import java.nio.charset.Charset;
 
 import static extension.CarEncoder.cupHolderCountNullValue;
 
@@ -38,9 +37,6 @@ public class ExampleUsingGeneratedStubExtension
  private static final baseline.MessageHeaderDecoder MESSAGE_HEADER_DECODER = new baseline.MessageHeaderDecoder();
  private static final baseline.MessageHeaderEncoder MESSAGE_HEADER_ENCODER = new baseline.MessageHeaderEncoder();
  private static final baseline.CarEncoder CAR_ENCODER_0 = new baseline.CarEncoder();
- private static final extension.CarEncoder CAR_ENCODER_1 = new extension.CarEncoder();
-
- private static final baseline.CarDecoder CAR_DECODER_0 = new baseline.CarDecoder();
  private static final extension.CarDecoder CAR_DECODER_1 = new extension.CarDecoder();
 
  static
@@ -51,7 +47,7 @@ public class ExampleUsingGeneratedStubExtension
  MANUFACTURER_CODE = "123".getBytes(baseline.EngineEncoder.manufacturerCodeCharacterEncoding());
  MAKE = "Honda".getBytes(baseline.CarEncoder.makeCharacterEncoding());
  MODEL = "Civic VTi".getBytes(baseline.CarEncoder.modelCharacterEncoding());
- ACTIVATION_CODE = new UnsafeBuffer(ByteBuffer.wrap(new byte[]{'d', 'e', 'a', 'd', 'b', 'e', 'e', 'f'}));
+ ACTIVATION_CODE = new UnsafeBuffer("abcdef".getBytes(baseline.CarEncoder.activationCodeCharacterEncoding()));
  }
  catch (final UnsupportedEncodingException ex)
  {
@@ -248,7 +244,8 @@ public static void decode(
 
  final UnsafeBuffer tempBuffer = new UnsafeBuffer(buffer);
  final int tempBufferLength = car.getActivationCode(tempBuffer, 0, tempBuffer.capacity());
- sb.append("\ncar.activationCode=").append(new String(buffer, 0, tempBufferLength, Charset.forName("UTF-8")));
+ sb.append("\ncar.activationCode=").append(
+ new String(buffer, 0, tempBufferLength, extension.CarEncoder.activationCodeCharacterEncoding()));
 
  sb.append("\ncar.encodedLength=").append(car.encodedLength());
 

sbe-tool/src/main/java/uk/co/real_logic/sbe/PrimitiveValue.java

@@ -17,7 +17,6 @@
 
 import java.io.UnsupportedEncodingException;
 import java.math.BigInteger;
-import java.nio.charset.Charset;
 import java.util.Arrays;
 
 import static java.lang.Double.doubleToLongBits;
@@ -155,7 +154,7 @@ public static PrimitiveValue parse(final String value, final PrimitiveType primi
  {
  throw new IllegalArgumentException("Constant char value malformed: " + value);
  }
- return new PrimitiveValue((long)value.getBytes(Charset.forName("UTF-8"))[0], 1);
+ return new PrimitiveValue((long)value.getBytes(forName("US-ASCII"))[0], 1);
 
  case INT8:
  return new PrimitiveValue(Byte.parseByte(value), 1);