Updated typing of expires_delta and fresh #510
Merged
+12 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cleaned up ExpiresDelta type definition and added Fresh type
updated typing for `expires_delta` and `fresh`
updated typing of `fresh`
updated typing for `fresh`
added missing import
float type is required while building the token_data dict in _encode_jwt
Owner
| Sorry this fell to the wayside for so long, life has been an absolute hectic mess over here 😅 Thanks for the PR! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I updated typing of two parameters:
expires_deltaandfreshaccording to expected type as per docstring and implementation.Resolves #509