Add good / bad binaries

Author: vikmik

Makefile

@@ -1,14 +1,17 @@
-.PHONY: all test
+.PHONY: all test testbinaries
 
 all: test
 
-testdata/repro:
+testbinaries:
 cd testdata && make
 
 dwarf-relocation-golang-bug: main.go
 go build
 
-test: testdata/repro dwarf-relocation-golang-bug
+test: testbinaries dwarf-relocation-golang-bug
+@echo "-------------------------"
+@./test.sh testdata/good
 @echo
-@echo "Running test"
-@./test.sh
+@echo "-------------------------"
+@./test.sh testdata/bad
+@echo "-------------------------"

main.go

@@ -4,10 +4,11 @@ import (
 "debug/elf"
 "fmt"
 "log"
+"os"
 )
 
 func main() {
-file, err := elf.Open("testdata/repro")
+file, err := elf.Open(os.Args[1])
 if err != nil {
 log.Fatal(err)
 }

test.sh

@@ -1,9 +1,13 @@
 #!/bin/bash -eu
+set -o pipefail
 
+file="$1"
+
+echo "Testing ${file}..."
 echo "Actual ranges:"
-llvm-dwarfdump testdata/repro --name=repro.c | grep -A2 DW_AT_ranges | tail -2 | sed 's/))/)/' | tr -d ' '
+llvm-dwarfdump ${file} --name=repro.c | grep -A2 DW_AT_ranges | tail -2 | sed -e 's/0x0*/0x/g' -e 's/))/)/' | tr -d ' '
 
 echo
 echo "Ranges derived from Golang's debug/elf + debug/dwarf"
-./dwarf-relocation-golang-bug
+./dwarf-relocation-golang-bug ${file}
 

testdata/.gitignore

@@ -1 +1,2 @@
-repro
+good
+bad

testdata/Makefile

@@ -1,7 +1,13 @@
 .PHONY: all
 
-repro: repro.c repro.ld
+all: bad good
+
+bad: repro.c repro.ld
 # The following command will likely print a warning (about a missing -T option), which should be ignored.
 # Removing the warning would require passing a fully-fledged linker script to bypass gcc's default.
-gcc -g $^ -Wl,--emit-relocs -o $@
+gcc -g $^ -Wl,--emit-relocs -Wl,--discard-none -o $@
+
+good: repro.c repro.ld
+# Same, but without --emit-relocs
+gcc -g $^ -o $@