Skip to content

Commit dd6baa2

Browse files
committed
Adds note about a potential breaking change in react 16
1 parent 6145b6f commit dd6baa2

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/server/ssr.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ function renderApp(res, store, assets, renderProps) {
99
const location = renderProps && renderProps.location && renderProps.location.pathname || '/';
1010
// Needed so some components can render based on location
1111
store.dispatch(push(location));
12+
13+
/**
14+
* Note: react-dom-strem is calling the PropTypes directly which will cause the code to break in
15+
* React 16, waiting on a PR for issue https://github.com/aickin/react-dom-stream/issues/22
16+
*
17+
* see https://facebook.github.io/react/warnings/dont-call-proptypes.html
18+
**/
19+
1220
const htmlStream = renderToStaticMarkup(
1321
<Html
1422
title="Super Future"

0 commit comments

Comments
 (0)