Skip to content

Commit 57ebb99

Browse files
author
MartijnVisser
authored
Merge pull request #49 from MartijnVisser/current_watermark-fix
Fixing incorrect comparison for CURRENT_WATERMARK
2 parents 7293b91 + 8c066ba commit 57ebb99

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

other-builtin-functions/03_current_watermark/03_current_watermark.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ CREATE TABLE `late_usage_events` (
5555
-- Create a view with non-late data
5656
CREATE TEMPORARY VIEW `mobile_data` AS
5757
SELECT * FROM mobile_usage
58-
WHERE CURRENT_WATERMARK(log_time) IS NOT NULL
59-
OR log_time < CURRENT_WATERMARK(log_time);
58+
WHERE CURRENT_WATERMARK(log_time) IS NULL
59+
OR log_time > CURRENT_WATERMARK(log_time);
6060

6161
-- Create a view with late data
6262
CREATE TEMPORARY VIEW `late_mobile_data` AS
6363
SELECT * FROM mobile_usage
64-
WHERE CURRENT_WATERMARK(log_time) IS NULL
65-
OR log_time > CURRENT_WATERMARK(log_time);
64+
WHERE CURRENT_WATERMARK(log_time) IS NOT NULL
65+
AND log_time <= CURRENT_WATERMARK(log_time);
6666

6767
BEGIN STATEMENT SET;
6868

@@ -83,3 +83,7 @@ END;
8383
## Example Output
8484

8585
![03_current_watermark](03_current_watermark.png)
86+
87+
### Late data
88+
89+
![03_late_data](03_late_data.png)
538 KB
Loading

0 commit comments

Comments
 (0)