Don't reset RequestCtx.s (#1234)

RequestCtx's are reused in a server specific pool, so no need to reset it. This fixes a use after reset but when RequestCtx is use as context. Fixes #1205

Author: erikdubbelboer

server.go

@@ -788,9 +788,14 @@ func (ctx *RequestCtx) reset() {
 ctx.connTime = zeroTime
 ctx.remoteAddr = nil
 ctx.time = zeroTime
-ctx.s = nil
 ctx.c = nil
 
+// Don't reset ctx.s!
+// We have a pool per server so the next time this ctx is used it
+// will be assigned the same value again.
+// ctx might still be in use for context.Done() and context.Err()
+// which are safe to use as they only use ctx.s and no other value.
+
 if ctx.timeoutResponse != nil {
 ctx.timeoutResponse.Reset()
 }