Skip to content

Conversation

@amir9480
Copy link
Contributor

image

There is one limitation that I couldn't fix. after undo/redo, values in the inspect tab are not updating.

@jordanisip jordanisip requested a review from cohitre August 13, 2024 18:15
@jordanisip
Copy link
Contributor

jordanisip commented Aug 13, 2024

Fantastic work, @amir9480. Appreciate the contribution. I'll leave the actual code review to @cohitre but a couple quick notes from my end:

  • I believe we can use the 'metaKey' keyboard event so it works for the different modifiers on mac vs pc. (Edit: it sounds like metaKey actually maps to the windows key on PC so maybe we'd need (event.ctrlKey || event.metaKey) to support cross-platform keyboard shortcuts?
  • It appears the first block that gets added doesn't activate the undo. I would have expected to undo back to the empty state in this case:

CleanShot 2024-08-13 at 14 27 10@2x

@rabiibrahimi
Copy link

Will this be reviewed and merged sometimes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants