Fix Promise#allOf(Promise<?>...) #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AllOfFuture completes with the list of values from each promise passed into its constructor. The varargs variant of Promise#allOf however has a return type of Void, so the intention seems to be to discard the results of the promises. Because a list of results is disjoint from Void any invocation of this method will throw an exception when the promises complete. To resolve this we explicitly discard the result of the promises by mapping the result to null, the only possible value of Void.
natemort requested review from Groxx, abhishekj720, demirkayaender, dkrotx and taylanisikdemir as code owners 
Pull Request Test Coverage Report for Build 2258Details
💛 - Coveralls |
shijiesheng approved these changes Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AllOfFuture completes with the list of values from each promise passed into its constructor. The varargs variant of Promise#allOf however has a return type of Void, so the intention seems to be to discard the results of the promises. Because a list of results is disjoint from Void any invocation of this method will throw an exception when the promises complete as we attempt to cast ArrayList to Void.
To resolve this we explicitly discard the result of the promises by mapping the result to null, the only possible value of Void.
What changed?
Change the behavior of Promise#allOf(Promise<?>...) to no longer throw an exception.
Why?
Allows for using Promise#allOf without wrapping the arguments in a collection first.
How did you test it?
Unit tests.
Potential risks
None
Release notes
Documentation Changes