Skip to content

Commit d26e9de

Browse files
chore(eslint-plugin): correct TODO comment on the wrong line (#11773)
* chore(eslint-plugin): update eslint recommended config Remove TODO and update comments related to `no-new-symbol` rule. The `no-new-symbol` rule was deprecated in ESLint 9.0.0 and will be removed in ESLint v11.0.0. We need to keep the rule disabled until TSESLint drops support for ESLint 8. (This commit message was automatically generated by an LLM.) * Update packages/eslint-plugin/src/configs/eslint-recommended-raw.ts Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * prettier --write --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
1 parent 3e38031 commit d26e9de

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

packages/eslint-plugin/src/configs/eslint-recommended-raw.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,13 @@ const config = (
2727
'no-dupe-keys': 'off', // ts(1117)
2828
'no-func-assign': 'off', // ts(2630)
2929
'no-import-assign': 'off', // ts(2632) & ts(2540)
30-
// TODO - remove this once we no longer support ESLint v8
3130
'no-new-native-nonconstructor': 'off', // ts(7009)
31+
// "no-new-symbol" was deprecated in ESLint 9.0.0 and will be removed in
32+
// ESLint v11.0.0. See:
33+
// https://eslint.org/docs/latest/rules/no-new-symbol
34+
// We need to keep the rule disabled until TSESLint drops support for
35+
// ESlint 8. See:
36+
// https://github.com/typescript-eslint/typescript-eslint/pull/8895
3237
'no-new-symbol': 'off', // ts(7009)
3338
'no-obj-calls': 'off', // ts(2349)
3439
'no-redeclare': 'off', // ts(2451)

0 commit comments

Comments
 (0)