bug symfony#54576 [Console] Better error handling when misuse of ArgvInput with arrays (symfonyaml)

This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Console] Better error handling when misuse of `ArgvInput` with arrays | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix symfony#53836 | License | MIT ### Issue When we don't use `ArgvInput` correclty, and use array in $argv values, it returns different PHP fatal errors. See all details and how to reproduce it in the issue symfony#53836 ### Solution In this PR - Add some DX with an exception explaining the problem, to avoid PHP fatal errors - Add tests** _____ Note : Old PR symfony#54147 was targeting 5.4, see [this comment](symfony#54147 (comment)) for more details Commits ------- 6f64cf4 [Console] Better error handling when misuse of `ArgvInput` with arrays

Author: fabpot

src/Symfony/Component/Console/Input/ArgvInput.php

@@ -49,6 +49,12 @@ public function __construct(?array $argv = null, ?InputDefinition $definition =
  {
  $argv ??= $_SERVER['argv'] ?? [];
 
+ foreach ($argv as $arg) {
+ if (!\is_scalar($arg) && !$arg instanceof \Stringable) {
+ throw new RuntimeException(sprintf('Argument values expected to be all scalars, got "%s".', get_debug_type($arg)));
+ }
+ }
+
  // strip the application name
  array_shift($argv);
 

src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php

@@ -324,6 +324,11 @@ public static function provideInvalidInput(): array
  new InputDefinition([new InputArgument('name', InputArgument::REQUIRED)]),
  'Too many arguments, expected arguments "name".',
  ],
+ [
+ ['cli.php', ['array']],
+ new InputDefinition(),
+ 'Argument values expected to be all scalars, got "array".',
+ ],
  ];
  }