chore(client): rename number methods

Author: puzpuzpuz

README.md

@@ -39,15 +39,15 @@ func main() {
 err = sender.
 Table("trades").
 Symbol("name", "test_ilp1").
-FloatColumn("value", 12.4).
+Float64Column("value", 12.4).
 AtNow(ctx)
 if err != nil {
 log.Fatal(err)
 }
 err = sender.
 Table("trades").
 Symbol("name", "test_ilp2").
-FloatColumn("value", 11.4).
+Float64Column("value", 11.4).
 At(ctx, time.Now().UnixNano())
 if err != nil {
 log.Fatal(err)

sender.go

@@ -248,8 +248,8 @@ func (s *LineSender) Table(name string) *LineSender {
 return s
 }
 
-// Symbol adds a symbol column (tag) value to the ILP message. Should be
-// called before any Column method.
+// Symbol adds a symbol column value to the ILP message. Should be called
+// before any Column method.
 //
 // Symbol name cannot contain any of the following characters:
 // '\n', '\r', '.', '?', ',', ':', '\\', '/', '\\0', ')', '(', '+', '*',
@@ -282,12 +282,13 @@ func (s *LineSender) Symbol(name, val string) *LineSender {
 return s
 }
 
-// IntColumn adds a 64-bit integer column value to the ILP message.
+// Int64Column adds a 64-bit integer (long) column value to the ILP
+// message.
 //
 // Column name cannot contain any of the following characters:
 // '\n', '\r', '.', '?', ',', ':', '\\', '/', '\\0', ')', '(', '+', '*',
 // '~', '%%', '-'.
-func (s *LineSender) IntColumn(name string, val int64) *LineSender {
+func (s *LineSender) Int64Column(name string, val int64) *LineSender {
 if !s.prepareForField(name) {
 return s
 }
@@ -302,12 +303,13 @@ func (s *LineSender) IntColumn(name string, val int64) *LineSender {
 return s
 }
 
-// FloatColumn adds a 64-bit float column value to the ILP message.
+// Float64Column adds a 64-bit float (double) column value to the ILP
+// message.
 //
 // Column name cannot contain any of the following characters:
 // '\n', '\r', '.', '?', ',', ':', '\\', '/', '\\0', ')', '(', '+', '*',
 // '~', '%%', '-'.
-func (s *LineSender) FloatColumn(name string, val float64) *LineSender {
+func (s *LineSender) Float64Column(name string, val float64) *LineSender {
 if !s.prepareForField(name) {
 return s
 }

sender_integration_test.go

@@ -232,8 +232,8 @@ func TestAllColumnTypes(t *testing.T) {
 err = sender.
 Table(testTable).
 Symbol("sym_col", "test_ilp1").
-FloatColumn("double_col", 12.2).
-IntColumn("long_col", 12).
+Float64Column("double_col", 12.2).
+Int64Column("long_col", 12).
 StringColumn("str_col", "foobar").
 BoolColumn("bool_col", true).
 At(ctx, 1000)
@@ -242,8 +242,8 @@ func TestAllColumnTypes(t *testing.T) {
 err = sender.
 Table(testTable).
 Symbol("sym_col", "test_ilp2").
-FloatColumn("double_col", 11.2).
-IntColumn("long_col", 11).
+Float64Column("double_col", 11.2).
+Int64Column("long_col", 11).
 StringColumn("str_col", "barbaz").
 BoolColumn("bool_col", false).
 At(ctx, 2000)
@@ -298,7 +298,7 @@ func TestWriteInBatches(t *testing.T) {
 for j := 0; j < nBatch; j++ {
 err = sender.
 Table(testTable).
-IntColumn("long_col", int64(j)).
+Int64Column("long_col", int64(j)).
 At(ctx, 1000*int64(i*nBatch+j))
 assert.NoError(t, err)
 }

sender_test.go

@@ -57,11 +57,11 @@ func TestValidWrites(t *testing.T) {
 {
 "multiple rows",
 func(s *qdb.LineSender) error {
-err := s.Table(testTable).StringColumn("str_col", "foo").IntColumn("long_col", 42).AtNow(ctx)
+err := s.Table(testTable).StringColumn("str_col", "foo").Int64Column("long_col", 42).AtNow(ctx)
 if err != nil {
 return err
 }
-err = s.Table(testTable).StringColumn("str_col", "bar").IntColumn("long_col", -42).At(ctx, 42)
+err = s.Table(testTable).StringColumn("str_col", "bar").Int64Column("long_col", -42).At(ctx, 42)
 if err != nil {
 return err
 }
@@ -75,7 +75,7 @@ func TestValidWrites(t *testing.T) {
 {
 "escaped chars in table name",
 func(s *qdb.LineSender) error {
-return s.Table("test 1\"2=3").IntColumn("a_col", 42).AtNow(ctx)
+return s.Table("test 1\"2=3").Int64Column("a_col", 42).AtNow(ctx)
 },
 []string{
 "test\\ 1\\\"2\\=3 a_col=42i\n",
@@ -159,7 +159,7 @@ func TestIntSerialization(t *testing.T) {
 sender, err := qdb.NewLineSender(ctx, qdb.WithAddress(srv.addr))
 assert.NoError(t, err)
 
-err = sender.Table(testTable).IntColumn("a_col", tc.val).AtNow(ctx)
+err = sender.Table(testTable).Int64Column("a_col", tc.val).AtNow(ctx)
 assert.NoError(t, err)
 
 err = sender.Flush(ctx)
@@ -202,7 +202,7 @@ func TestFloatSerialization(t *testing.T) {
 sender, err := qdb.NewLineSender(ctx, qdb.WithAddress(srv.addr))
 assert.NoError(t, err)
 
-err = sender.Table(testTable).FloatColumn("a_col", tc.val).AtNow(ctx)
+err = sender.Table(testTable).Float64Column("a_col", tc.val).AtNow(ctx)
 assert.NoError(t, err)
 
 err = sender.Flush(ctx)
@@ -523,13 +523,13 @@ func TestErrorOnMissingTableCall(t *testing.T) {
 {
 "long column",
 func(s *qdb.LineSender) error {
-return s.IntColumn("int", 42).AtNow(ctx)
+return s.Int64Column("int", 42).AtNow(ctx)
 },
 },
 {
 "double column",
 func(s *qdb.LineSender) error {
-return s.FloatColumn("float", 4.2).AtNow(ctx)
+return s.Float64Column("float", 4.2).AtNow(ctx)
 },
 },
 }
@@ -592,13 +592,13 @@ func TestErrorOnSymbolCallAfterColumn(t *testing.T) {
 {
 "integer column",
 func(s *qdb.LineSender) error {
-return s.Table("awesome_table").IntColumn("int", 42).Symbol("sym", "abc").AtNow(ctx)
+return s.Table("awesome_table").Int64Column("int", 42).Symbol("sym", "abc").AtNow(ctx)
 },
 },
 {
 "float column",
 func(s *qdb.LineSender) error {
-return s.Table("awesome_table").FloatColumn("float", 4.2).Symbol("sym", "abc").AtNow(ctx)
+return s.Table("awesome_table").Float64Column("float", 4.2).Symbol("sym", "abc").AtNow(ctx)
 },
 },
 }
@@ -723,8 +723,8 @@ func BenchmarkLineSender(b *testing.B) {
 sender.
 Table(testTable).
 Symbol("sym_col", "test_ilp1").
-FloatColumn("double_col", float64(i)+0.42).
-IntColumn("long_col", int64(i)).
+Float64Column("double_col", float64(i)+0.42).
+Int64Column("long_col", int64(i)).
 StringColumn("str_col", "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua").
 BoolColumn("bool_col", true).
 At(ctx, int64(1000*i))