Skip to content

Commit c50e572

Browse files
committed
Feat: CREATE SYNOPSIS from model on join table
1 parent 4c355aa commit c50e572

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

traindb-core/src/main/java/traindb/engine/TrainDBQueryEngine.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,7 @@ private void createSynopsisTable(String synopsisName, String schemaName, String
504504

505505
SqlDialect dialect = schemaManager.getDialect();
506506
if (importSynopsis
507+
|| mTable.getTableType().equals("JOIN")
507508
|| (dialect instanceof TrainDBSqlDialect
508509
&& !((TrainDBSqlDialect) dialect).supportCreateTableAsSelect())) {
509510
sb.append("(");
@@ -829,6 +830,7 @@ public void createSynopsis(String synopsisName, TrainDBSqlCommand.SynopsisType s
829830
catalogContext.createExternalTable(synopsisName, "csv", synPath.toString());
830831
conn.refreshRootSchema();
831832
T_tracer.closeTaskTime("SUCCESS");
833+
T_tracer.endTaskTracer();
832834
return;
833835
}
834836

@@ -840,6 +842,7 @@ public void createSynopsis(String synopsisName, TrainDBSqlCommand.SynopsisType s
840842
loadSynopsisIntoTable(synopsisName, mModel.getSchemaName(), mModel.getColumnNames(),
841843
mModel.getTable(), outputPath);
842844
T_tracer.closeTaskTime("SUCCESS");
845+
T_tracer.endTaskTracer();
843846
} catch (Exception e) {
844847
try {
845848
dropSynopsisTable(synopsisName);
@@ -854,8 +857,6 @@ public void createSynopsis(String synopsisName, TrainDBSqlCommand.SynopsisType s
854857

855858
throw new TrainDBException(msg);
856859
}
857-
T_tracer.closeTaskTime("SUCCESS");
858-
T_tracer.endTaskTracer();
859860
}
860861

861862
private void dropSynopsisTable(String synopsisName) throws Exception {

0 commit comments

Comments
 (0)