GitHub actions to build on multiple environments (linux and windows) (codecentric#1630)

* codecentric#1622: Using Actions matrix build feature to also build on Windows * codecentric#1622: Fixing `Unknown lifecycle phase ".javadoc.skip=true"` error on Windows builds. * codecentric#1622: Fixing problems on Windows with spring-javaformat-maven-plugin * Tagged testcases using docker * if docker isn't installed, they won't fail the build anymore * can be excluded using -DexcludedGroups=docker * codecentric#1622: Add springjava-format apply to PR GHA workflow. Also switched to verify in all build workflows. Co-authored-by: Jonas Hecht <jonas.hecht@codecentric.de>

Author: ccoltx

.github/workflows/build-feature.yml

@@ -9,7 +9,11 @@ on:
 
 jobs:
  build:
- runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ os: [ubuntu-latest, windows-2016]
+
+ runs-on: ${{ matrix.os }}
  steps:
 
  - uses: actions/checkout@v2
@@ -19,8 +23,12 @@ jobs:
  with:
  java-version: 1.8
 
+ # since we also build on Windows Powershell, we need to add a space between -D maven.javadoc.skip=true
+ # otherwise the build will fail https://stackoverflow.com/questions/38051787/maven-javadoc-skip-true-throws-an-error
  - name: Build with Maven
- run: mvn -B install -P coverage --no-transfer-progress -Dmaven.javadoc.skip=true
+ run: |
+ mvn -B spring-javaformat:apply --no-transfer-progress
+ mvn -B verify -P coverage --no-transfer-progress -D maven.javadoc.skip=true
 
  - uses: codecov/codecov-action@v1
  with:

.github/workflows/build-main.yml

@@ -9,7 +9,11 @@ on:
 
 jobs:
  build:
- runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ os: [ubuntu-latest, windows-2016]
+
+ runs-on: ${{ matrix.os }}
  steps:
 
  - uses: actions/checkout@v2
@@ -19,8 +23,12 @@ jobs:
  with:
  java-version: 1.8
 
+ # since we also build on Windows Powershell, we need to add a space between -D maven.javadoc.skip=true
+ # otherwise the build will fail https://stackoverflow.com/questions/38051787/maven-javadoc-skip-true-throws-an-error
  - name: Build with Maven
- run: mvn -B install -P coverage --no-transfer-progress -Dmaven.javadoc.skip=true
+ run: |
+ mvn -B spring-javaformat:apply --no-transfer-progress
+ mvn -B verify -P coverage --no-transfer-progress -D maven.javadoc.skip=true
 
  - uses: codecov/codecov-action@v1
  with:

.github/workflows/build-pullrequest.yml

@@ -5,7 +5,11 @@ on:
 
 jobs:
  build:
- runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ os: [ubuntu-latest, windows-2016]
+
+ runs-on: ${{ matrix.os }}
  steps:
 
  - uses: actions/checkout@v2
@@ -15,8 +19,12 @@ jobs:
  with:
  java-version: 1.8
 
+ # since we also build on Windows Powershell, we need to add a space between -D maven.javadoc.skip=true
+ # otherwise the build will fail https://stackoverflow.com/questions/38051787/maven-javadoc-skip-true-throws-an-error
  - name: Build with Maven
- run: mvn -B install -P coverage --no-transfer-progress -Dmaven.javadoc.skip=true
+ run: |
+ mvn -B spring-javaformat:apply --no-transfer-progress
+ mvn -B verify -P coverage --no-transfer-progress -D maven.javadoc.skip=true
 
  - uses: codecov/codecov-action@v1
  with:

spring-boot-admin-server/src/test/java/de/codecentric/boot/admin/server/eventstore/HazelcastEventStoreWithClientConfigTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2014-2020 the original author or authors.
+ * Copyright 2014-2021 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
 import com.hazelcast.client.config.ClientConfig;
 import com.hazelcast.core.HazelcastInstance;
 import com.hazelcast.map.IMap;
+import org.junit.jupiter.api.Tag;
 import org.springframework.boot.autoconfigure.hazelcast.HazelcastClientFactory;
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.junit.jupiter.Container;
@@ -29,11 +30,12 @@
 import de.codecentric.boot.admin.server.domain.events.InstanceEvent;
 import de.codecentric.boot.admin.server.domain.values.InstanceId;
 
-@Testcontainers
+@Testcontainers(disabledWithoutDocker = true)
+@Tag("docker")
 public class HazelcastEventStoreWithClientConfigTest extends AbstractEventStoreTest {
 
 @Container
-private static final GenericContainer hazelcastServer = new GenericContainer("hazelcast/hazelcast:4.0")
+private static final GenericContainer<?> hazelcastServer = new GenericContainer<>("hazelcast/hazelcast:4.0")
 .withExposedPorts(5701);
 
 private final HazelcastInstance hazelcast;