Merge pull request cpp-best-practices#7 from saimen/fix-use-of-cmake-options

Fix use of cmake options

Author: lefticus

CMakeLists.txt

@@ -1,11 +1,11 @@
 cmake_minimum_required(VERSION 3.8)
 
-option(BUILD_SHARED_LIBS "Enable compilation of shared libraries" FALSE)
-option(CPP_STARTER_USE_QT "Enable compilation of QT sample" FALSE)
-option(CPP_STARTER_USE_FLTK "Enable compilation of FLTK sample" FALSE)
-option(CPP_STARTER_USE_GTKMM "Enable compilation of GTKMM sample" FALSE)
-option(CPP_STARTER_USE_IMGUI "Enable compilation of ImGui sample" FALSE)
-option(CPP_STARTER_USE_NANA "Enable compilation of Nana GUI sample" FALSE)
+option(BUILD_SHARED_LIBS "Enable compilation of shared libraries" OFF)
+option(CPP_STARTER_USE_QT "Enable compilation of QT sample" OFF)
+option(CPP_STARTER_USE_FLTK "Enable compilation of FLTK sample" OFF)
+option(CPP_STARTER_USE_GTKMM "Enable compilation of GTKMM sample" OFF)
+option(CPP_STARTER_USE_IMGUI "Enable compilation of ImGui sample" OFF)
+option(CPP_STARTER_USE_NANA "Enable compilation of Nana GUI sample" OFF)
 
 # Link this 'library' to use the following warnings
 add_library(project_warnings INTERFACE)
@@ -63,21 +63,21 @@ target_link_libraries(tester PRIVATE project_warnings --coverage)
 add_test(Tester tester)
 
 # qt
-if(DEFINED CPP_STARTER_USE_QT)
+if(CPP_STARTER_USE_QT)
  message("Using Qt")
  add_subdirectory(qt)
 endif()
 
 # fltk test
-if(DEFINED CPP_STARTER_USE_FLTK)
+if(CPP_STARTER_USE_FLTK)
  find_package(FLTK REQUIRED)
  add_executable(test_fltk fltk/test_fltk.cpp)
  target_link_libraries(test_fltk PRIVATE project_warnings ${FLTK_LIBRARIES})
  target_include_directories(test_fltk PRIVATE ${FLTK_INCLUDE_DIR})
 endif()
 
 # gtkmm test
-if(DEFINED CPP_STARTER_USE_GTKMM)
+if(CPP_STARTER_USE_GTKMM)
  find_package(PkgConfig REQUIRED)
  pkg_check_modules(GTKMM REQUIRED gtkmm-3.0)
  add_executable(test_gtkmm gtkmm/main.cpp gtkmm/hello_world.cpp)
@@ -86,7 +86,7 @@ if(DEFINED CPP_STARTER_USE_GTKMM)
 endif()
 
 # imgui example
-if(DEFINED CPP_STARTER_USE_IMGUI)
+if(CPP_STARTER_USE_IMGUI)
  find_package(SFML COMPONENTS graphics window system)
  find_package(OpenGL)
 
@@ -101,7 +101,7 @@ if(DEFINED CPP_STARTER_USE_IMGUI)
 endif()
 
 # Nana
-if(DEFINED CPP_STARTER_USE_NANA)
+if(CPP_STARTER_USE_NANA)
  include(ExternalProject)
  externalproject_add(Nana
  GIT_REPOSITORY