Make 'recalculateLineNumberPreferredSize' faster

Logs are always in sequential order. There is no need to iterate over all logs in order to find the greatest index if they are stored in an array. We can simply access the last element and get its index

Author: tibagni

src/main/java/com/tibagni/logviewer/LogViewerView.kt

@@ -439,7 +439,7 @@ class LogViewerViewImpl(private val mainView: MainView, initialLogFiles: Set<Fil
  .map { model.getValueAt(it, 0) as LogEntry }
  .forEach { myLogsListTableModel.addLog(it) }
  sidePanel.showMyLogsView()
- myLogsRenderer.recalculateLineNumberPreferredSize(myLogsListTableModel)
+ myLogsListTableModel.lastEntry?.let { myLogsRenderer.recalculateLineNumberPreferredSize(it.index) }
  }
 
  if (selectedRows.size == 1) {
@@ -510,7 +510,7 @@ class LogViewerViewImpl(private val mainView: MainView, initialLogFiles: Set<Fil
  myLogsList.table.selectedRows
  .map { myLogsListTableModel.getValueAt(it, 0) as LogEntry }
  .forEach { myLogsListTableModel.removeLog(it) }
- myLogsRenderer.recalculateLineNumberPreferredSize(myLogsListTableModel)
+ myLogsListTableModel.lastEntry?.let { myLogsRenderer.recalculateLineNumberPreferredSize(it.index) }
  }
 
  myLogsList.table.addMouseListener(object : MouseAdapter() {
@@ -699,7 +699,7 @@ class LogViewerViewImpl(private val mainView: MainView, initialLogFiles: Set<Fil
  override fun showLogs(logEntries: List<LogEntry>?) {
  logListTableModel.setLogs(logEntries)
  // calc the line number view needed width
- logRenderer.recalculateLineNumberPreferredSize(logListTableModel)
+ logEntries?.lastOrNull()?.let { logRenderer.recalculateLineNumberPreferredSize(it.index) }
  }
 
  override fun showCurrentLogsLocation(logsPath: String?) {

src/main/java/com/tibagni/logviewer/log/LogCellRenderer.java

@@ -89,25 +89,17 @@ public void highlightLine(int rowIndex) {
  mHighlightLine = rowIndex;
  }
 
- public void recalculateLineNumberPreferredSize(LogListTableModel model) {
- if (!lineNumLabel.isVisible()) return;
-
- int maxIndex = -1;
- for (int index = 0; index < model.getRowCount(); index++) {
- LogEntry logEntry = (LogEntry) model.getValueAt(index, 0);
- if (logEntry.getIndex() > maxIndex) {
- maxIndex = logEntry.getIndex();
- }
+ public void recalculateLineNumberPreferredSize(int maxLineNumber) {
+ if (!lineNumLabel.isVisible()) {
+ return;
  }
 
- if (maxIndex != -1) {
- String line = String.valueOf(maxIndex + 1);
- int width = (int) getFont().getStringBounds(line, fontRenderContext).getWidth();
+ String line = String.valueOf(maxLineNumber + 1);
+ int width = (int) getFont().getStringBounds(line, fontRenderContext).getWidth();
 
- // size = string width + border size
- lineNumLabel.setPreferredSize(new Dimension(width + UIScaleUtils.dip(15),
- lineNumLabel.getPreferredSize().height));
- }
+ // size = string width + border size
+ lineNumLabel.setPreferredSize(new Dimension(width + UIScaleUtils.dip(15),
+ lineNumLabel.getPreferredSize().height));
  }
 
  @Override

src/main/java/com/tibagni/logviewer/log/LogListTableModel.java

@@ -1,5 +1,7 @@
 package com.tibagni.logviewer.log;
 
+import org.jetbrains.annotations.Nullable;
+
 import javax.swing.table.AbstractTableModel;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -39,6 +41,14 @@ public Object getValueAt(int rowIndex, int columnIndex) {
  return entries.get(rowIndex);
  }
 
+ public @Nullable LogEntry getLastEntry() {
+ if (entries.isEmpty()) {
+ return null;
+ }
+
+ return entries.get(entries.size() - 1);
+ }
+
  public void setLogs(List<LogEntry> entries) {
  this.entries.clear();
  this.entries.addAll(entries);