Skip to content

Conversation

@tiangolo
Copy link
Member

@tiangolo tiangolo commented Aug 24, 2021

💚 Fix CI installs and tests.

Poetry 1.2.0ax currently has an issue that was solved here: python-poetry/poetry-core#188, but is not released in the alpha branches.

This project uses Poetry 1.2.0ax to be able to use the Poetry Version Plugin https://github.com/tiangolo/poetry-version-plugin

Until there's a new release with that fix, this change installs poetry-core from Git, pinned to the version that fixes the problem.

This PR also fixes several dangling issues detected by the first CI runs, missing dev dependencies, type annotations, etc.

@tiangolo tiangolo changed the title 💚 Fix Poetry install in CI 💚 Fix CI installs and tests Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ed0d670). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## main #2 +/- ## ======================================= Coverage ? 97.24% ======================================= Files ? 175 Lines ? 5842 Branches ? 0 ======================================= Hits ? 5681 Misses ? 161 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0d670...4a5cda8. Read the comment docs.

@github-actions github-actions bot temporarily deployed to commit August 24, 2021 18:13 Inactive
@github-actions
Copy link
Contributor

@tiangolo tiangolo merged commit 7f8a1a5 into main Aug 24, 2021
@tiangolo tiangolo deleted the fix-poetry-ci branch August 24, 2021 18:14
tiangolo pushed a commit that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants