Skip to content

Conversation

@tiangolo
Copy link
Member

🎨 Fix type detection of select results in PyCharm

It seems that for some reason PyCharm is probably mixing the same TypeVar _T from another _T in another file (or maybe I'm wrong?) but still, renaming it seems to fix it. 🚀

Reported in a Tweet 😅 https://twitter.com/paulweveritt/status/1430326020511518725

@tiangolo tiangolo enabled auto-merge (squash) August 25, 2021 13:43
@github-actions
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #15 (ce60193) into main (af03df8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #15 +/- ## ======================================= Coverage 97.24% 97.24% ======================================= Files 175 175 Lines 5842 5842 ======================================= Hits 5681 5681 Misses 161 161 
Impacted Files Coverage Δ
sqlmodel/orm/session.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af03df8...ce60193. Read the comment docs.

@tiangolo tiangolo merged commit 1da849a into main Aug 25, 2021
@tiangolo tiangolo deleted the fix-type-detection-in-pycharm branch August 25, 2021 13:43
synodriver pushed a commit to synodriver/sqlmodel that referenced this pull request Jun 24, 2022
feat: add foreign_key name to wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants