Clean up (appium#993)

* Remove unused imports * Fix checkstyle warning * Fix generic type references * Fix JavaDocs

Author: valfirst

src/main/java/io/appium/java_client/MobileElement.java

@@ -91,9 +91,8 @@ public List<MobileElement> findElementsByXPath(String using) {
  *
  * @param value is the new value which should be set
  */
- @SuppressWarnings({"rawtypes", "unchecked"})
  public void setValue(String value) {
- ImmutableMap.Builder builder = ImmutableMap.builder();
+ ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
  builder.put("id", id).put("value", value);
  execute(MobileCommand.SET_VALUE, builder.build());
  }

src/main/java/io/appium/java_client/ScreenshotState.java

@@ -40,8 +40,8 @@ public class ScreenshotState {
  private Duration comparisonInterval = DEFAULT_INTERVAL_MS;
 
  /**
- * The class constructor accepts single argument, which is
- * lambda function, that provides the screenshot of the necessary
+ * The class constructor accepts two arguments. The first one is image comparator, the second
+ * parameter is lambda function, that provides the screenshot of the necessary
  * screen area to be verified for similarity.
  * This lambda method is NOT called upon class creation.
  * One has to invoke {@link #remember()} method in order to call it.
@@ -67,6 +67,7 @@ public class ScreenshotState {
  * }
  * </code>
  *
+ * @param comparator image comparator
  * @param stateProvider lambda function, which returns a screenshot for further comparison
  */
  public ScreenshotState(ComparesImages comparator, Supplier<BufferedImage> stateProvider) {

src/main/java/io/appium/java_client/TouchAction.java

@@ -84,8 +84,8 @@ public T release() {
  * Important: some older Appium drivers releases have a bug when moveTo
  * coordinates are calculated as relative to the recent pointer position
  * in the chain instead of being absolute.
- * @see <a href="https://github.com/appium/appium/issues/7486">Appium Issue #7486</a>
- * for more details.
+ * @see <a href="https://github.com/appium/appium/issues/7486">Appium Issue #7486
+ * for more details.</a>
  * @return this TouchAction, for chaining.
  */
  public T moveTo(PointOption moveToOptions) {

src/main/java/io/appium/java_client/android/AndroidStartScreenRecordingOptions.java

@@ -81,11 +81,11 @@ public AndroidStartScreenRecordingOptions enableBugReport() {
  * Setting values greater than this or less than zero will cause an exception. The minimum
  * time resolution unit is one second.
  *
- * Since Appium 1.8.2 the time limit can be up to 1800 seconds (30 minutes).
+ * <p>Since Appium 1.8.2 the time limit can be up to 1800 seconds (30 minutes).
  * Appium will automatically try to merge the 3-minutes chunks recorded
  * by the screenrecord utility, however, this requires FFMPEG utility
  * to be installed and available in PATH on the server machine. If the utility is not
- * present then the most recent screen recording chunk is going to be returned as the result.
+ * present then the most recent screen recording chunk is going to be returned as the result.</p>
  *
  * @param timeLimit The actual time limit of the recorded video.
  * @return self instance for chaining.

src/main/java/io/appium/java_client/android/appmanagement/AndroidInstallApplicationOptions.java

@@ -137,10 +137,9 @@ public AndroidInstallApplicationOptions withGrantPermissionsDisabled() {
  return this;
  }
 
- @SuppressWarnings("unchecked")
  @Override
  public Map<String, Object> build() {
- final ImmutableMap.Builder builder = new ImmutableMap.Builder<String, Object>();
+ final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
  ofNullable(replace).map(x -> builder.put("replace", x));
  ofNullable(timeout).map(x -> builder.put("timeout", x.toMillis()));
  ofNullable(allowTestPackages).map(x -> builder.put("allowTestPackages", x));

src/main/java/io/appium/java_client/android/appmanagement/AndroidRemoveApplicationOptions.java

@@ -67,10 +67,9 @@ public AndroidRemoveApplicationOptions withKeepDataDisabled() {
  return this;
  }
 
- @SuppressWarnings("unchecked")
  @Override
  public Map<String, Object> build() {
- final ImmutableMap.Builder builder = new ImmutableMap.Builder<String, Object>();
+ final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
  ofNullable(timeout).map(x -> builder.put("timeout", x.toMillis()));
  ofNullable(keepData).map(x -> builder.put("keepData", x));
  return builder.build();

src/main/java/io/appium/java_client/android/appmanagement/AndroidTerminateApplicationOptions.java

@@ -44,10 +44,9 @@ public AndroidTerminateApplicationOptions withTimeout(Duration timeout) {
  return this;
  }
 
- @SuppressWarnings("unchecked")
  @Override
  public Map<String, Object> build() {
- final ImmutableMap.Builder builder = new ImmutableMap.Builder<String, Object>();
+ final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
  ofNullable(timeout).map(x -> builder.put("timeout", x.toMillis()));
  return builder.build();
  }

src/main/java/io/appium/java_client/android/nativekey/AndroidKey.java

@@ -1335,6 +1335,8 @@ public boolean isGamepadButton() {
 
  /**
  * Whether key will, by default, trigger a click on the focused view.
+ *
+ * @return true if this is a confirm key.
  */
  public boolean isConfirmKey() {
  switch (this) {
@@ -1351,6 +1353,8 @@ public boolean isConfirmKey() {
  /**
  * Whether this key is a media key, which can be send to apps that are
  * interested in media key events.
+ *
+ * @return true if this is a media key.
  */
  public boolean isMediaKey() {
  switch (this) {
@@ -1374,6 +1378,8 @@ public boolean isMediaKey() {
 
  /**
  * Is this a system key? System keys can not be used for menu shortcuts.
+ *
+ * @return true if this is a system key.
  */
  public boolean isSystemKey() {
  switch (this) {
@@ -1413,7 +1419,7 @@ public boolean isSystemKey() {
  /**
  * Is it wake key or not.
  *
- * @return true if this a wakeup key.
+ * @return true if this is a wakeup key.
  */
  public boolean isWakeKey() {
  switch (this) {
@@ -1429,4 +1435,4 @@ public boolean isWakeKey() {
  return false;
  }
  }
-}
+}

src/main/java/io/appium/java_client/events/api/general/WindowEventListener.java

@@ -83,6 +83,7 @@ void afterWindowIsMoved(WebDriver driver, WebDriver.Window window,
  * This action will be performed each time before
  * {@link org.openqa.selenium.WebDriver.TargetLocator#window(java.lang.String)}.
  *
+ * @param windowName the name of the window to switch
  * @param driver WebDriver
  */
  void beforeSwitchToWindow(String windowName, WebDriver driver);
@@ -91,6 +92,7 @@ void afterWindowIsMoved(WebDriver driver, WebDriver.Window window,
  * This action will be performed each time after
  * {@link org.openqa.selenium.WebDriver.TargetLocator#window(java.lang.String)}.
  *
+ * @param windowName the name of the window to switch
  * @param driver WebDriver
  */
  void afterSwitchToWindow(String windowName, WebDriver driver);

src/main/java/io/appium/java_client/imagecomparison/BaseComparisonOptions.java

@@ -44,9 +44,8 @@ public T withEnabledVisualization() {
  *
  * @return comparison options mapping.
  */
- @SuppressWarnings("unchecked")
  public Map<String, Object> build() {
- final ImmutableMap.Builder builder = new ImmutableMap.Builder<String, Object>();
+ final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
  ofNullable(visualize).map(x -> builder.put("visualize", x));
  return builder.build();
  }