Skip to content

Commit d78e33a

Browse files
authored
Merge pull request #213 from coreycb/approval-request
Update uplift approval request form
2 parents 32dbcf8 + 35ce419 commit d78e33a

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

releases/uplifting-fixes.md

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,35 +47,41 @@ Ensure uplift requests are submitted at least two working days prior to any sche
4747

4848
### **Uplift Request Form**
4949

50-
**[User impact if declined]**
50+
**Please state case for uplift consideration and ensure bug severity is set**
51+
- Ensure the fix adheres to criteria specified in [Uplifts to Beta](uplifting-fixes#uplifts-to-beta) or [Uplifts to Release and ESR](uplifting-fixes#uplifts-to-release-and-esr).
52+
53+
**User impact if declined**
5154
- Provide details on how an end user would be impacted with or without this change. In addition to the Steps to Reproduce (STR), explain the deeper implications for users.
5255

53-
**[Is this code covered by automated tests?]**
54-
- Options: Yes / No / Unknown.
56+
**Is this code covered by automated tests?**
57+
- Options: Yes / No / Unknown
58+
59+
**Has the fix been verified in Daily?**
60+
- Options: Yes / No / N/A
5561

56-
**[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]**
57-
- Indicate whether the fix has been verified in a Daily or Beta build, and by whom (e.g., the reporter or QA).
62+
**Has the fix been verified in Beta?**
63+
- Options: Yes / No / N/A
5864

59-
**[Needs manual test from QA?]**
60-
- Options: Yes / No.
65+
**Needs manual test from QA?**
66+
- Options: Yes / No
6167
- If "Yes," include the steps to reproduce either by referencing an existing comment with STR or elaborating directly.
6268

63-
**[List of other uplifts needed]**
69+
**List of other uplifts needed**
6470
- If this patch depends on other changes not present on the target branch, list those dependencies here.
6571
- Ensure approval is also requested for dependent patches.
6672

67-
**[Risk to taking this patch]**
68-
- Options: Low / Medium / High.
73+
**Risk to taking this patch**
74+
- Options: Low / Medium / High
6975
- Provide a justification as to why the benefits of the uplift outweighs the associated risks.
7076

7177
Examples:
7278
- **Low**: A one-line CSS change impacting only the settings page.
7379
- **Medium**: Due to code complexity and integration with other areas, there might be regressions in related functionality.
7480
- **High**: The patch involves complex changes with a high likelihood of fallout or regressions, which may require extensive manual testing or mitigation strategies.
7581

76-
**[Why is the change risky/not risky? (and alternatives if risky)]**
82+
**Why is the change risky/not risky? (and alternatives if risky)**
7783
- If the change is risky, explain the potential impact. In other words, describe the potential negative impacts that could occur if the change leads to a regression. What mitigations were taken to reduce the risk? What alternative solutions were considered?
7884

79-
**[String changes made/needed]**
85+
**String changes made/needed**
8086
- Answer "none" if no string changes were made.
8187
- If there are string changes, add details and justification to help with l10n review.

0 commit comments

Comments
 (0)