Skip to content

Conversation

@nbloomf
Copy link

@nbloomf nbloomf commented Jul 8, 2020

The immediate purpose of this PR is to aid in testing #128, as the WordPress.com oauth2 implementation requires form parameter style client credentials when fetching the token. That PR has a link to a live test implementation.

Documentation for this integration is at https://developer.wordpress.com/docs/wpcc/

@nbloomf nbloomf marked this pull request as ready for review July 8, 2020 14:01
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM -- is it ready to merge?

@nbloomf
Copy link
Author

nbloomf commented Jul 8, 2020

I think so; I tested it and it doesn't look like there's a need parameterize this further (e.g. to allow custom scopes).

@pbrisbin
Copy link
Member

Sorry I lost track of this! I'll merge it this week, once I work out the CI issues in pb/next.

@pbrisbin pbrisbin merged commit 40119bd into freckle:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants