Support Rails 5 static file serving configuration. #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
houndci-bot reviewed Oct 23, 2016
spec/dummy/application.rb Outdated
| config.static_cache_control = CACHE_CONTROL_FIVE_MINUTES | ||
| if Rails.version >= '5' | ||
| config.public_file_server.headers = { | ||
| 'Cache-Control' => CACHE_CONTROL_FIVE_MINUTES |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Put a comma after the last item of a multiline hash.
| @pwnall thanks for opening this pull request! The code changes look good to me. I'm working on a separate PR to update our CI configuration to allow failures on Once that lands, I'll rebase and merge this. Thanks again! |
| Merged in c2bdeb9. Thanks! |
| @seanpdoyle Thank you very much for the quick turnaround time, and for the general awesomeness of this gem! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Source documenting the new Rails 5 configuration method: Rails guides -- look for section 4.4.2.3 CDNs and the Cache-Control Header
Thank you for the gem!