Allow --silent option for commands to quiet the output #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spec/lib/ember_cli/command_spec.rb Outdated
| end | ||
| | ||
| context 'when configured to be silent' do | ||
| it 'includes includes `--silent` flag' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @smolnar thanks for the PR, this looks great! Could you add something to the Setup section of the README about ? |
| @seanpdoyle thanks! Oh, completely forgot about that. Will do! |
| @seanpdoyle done! 💃 |
| @seanpdoyle any update on this? |
| Merged in 5416441. Thanks! |
| Awesome, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In my case, cucumber specs output is disrupted a bit by the ember-cli build output, so hence the PR.