Skip to content

Conversation

@aszenz
Copy link
Contributor

@aszenz aszenz commented Jan 27, 2024

Follow up of 0ccb1a2

To support dbal v3 fully i bumped up the dependencies and php versions

Also added github ci and removed travis

+ Upgrade phpunit and fix tests + Fix passing null to strpos triggering warning on new php + Raise doctrine/cache to v1.4.1 since void cache was not in 1.4
+ Remove travis
@aszenz
Copy link
Contributor Author

aszenz commented Jan 27, 2024

@nguyenk This pr should make releasing v2 possible

Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this ! Just a small concern about a test and then it is ready to merge.

Co-authored-by: homersimpsons <guillaume.alabre@gmail.com>
@aszenz
Copy link
Contributor Author

aszenz commented Feb 1, 2024

Thank you for your work on this ! Just a small concern about a test and then it is ready to merge.

Applied the suggestion, the assertion message is different than expectedException message indeed

@homersimpsons homersimpsons merged commit 263de74 into thecodingmachine:2.0 Feb 1, 2024
@homersimpsons
Copy link
Contributor

Thank you for your contribution !

I saw you had some open Pull Request targeting your own forks. Maybe those are not ready yet, or the target is not correct:

@aszenz
Copy link
Contributor Author

aszenz commented Feb 1, 2024

Thank you for your contribution !

I saw you had some open Pull Request targeting your own forks. Maybe those are not ready yet, or the target is not correct:

* [Use v2 of schema-analyzer aszenz/magic-query#1](https://github.com/aszenz/magic-query/pull/1) * [Update dbal to v3 aszenz/schema-version-control#1](https://github.com/aszenz/schema-version-control/pull/1) 

Those are for testing the ci pipeline, i'll create more pr's in original repos soon

@aszenz
Copy link
Contributor Author

aszenz commented Feb 1, 2024

Can u do a release of v2 as well, or something else needs merging

@homersimpsons
Copy link
Contributor

Can u do a release of v2 as well, or something else needs merging

I did a pre-release:

If it is stable, I can do a real release. I do not think we have to merge anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants