feat: Drop support for Node.js 14.x and Node.js 16.x and add support for Node 20.x #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BREAKING CHANGE: Minimum supported Node.js version is now 14.x
…obi/dom-testing-library into features/drop-support-for-node-14
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 86beed6:
|
Codecov Report
@@ Coverage Diff @@ ## alpha #1255 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 24 24 Lines 1038 1038 Branches 349 349 ========================================= Hits 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timdeschryver approved these changes Sep 9, 2023
There was a problem hiding this comment.
As you've mentioned @MatanBobi , it would be better to get this in together with #1241
MatanBobi changed the title This was referenced Sep 10, 2023
nickserv approved these changes Sep 10, 2023
| Feel free to merge if you're ready. I think it would be helpful to base other alpha PRs off this to avoid noise in CI. |
This was referenced Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Minimum supported Node.js version is now 18.x
What: This PR drops support for Node 14 and Node 16.
Why: Node 14 was declared EOL on May 23, Node 16 will be declared EOL on September 11.
How: Upgrade all relevant places.
Checklist:
- [ ] Documentation added to thedocs site
- [] TypeScript definitions updated